components/cronet/tools/check_no_neon.py - Issue 2060333002: [Cronet] Enforce ARMv7 Cronet doesn't inadvertently use ARM Neon instructions

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/cronet/tools/check_no_neon.py

Issue 2060333002: [Cronet] Enforce ARMv7 Cronet doesn't inadvertently use ARM Neon instructions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: disable neon on bots Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 #!/usr/bin/python

	2 # Copyright 2016 The Chromium Authors. All rights reserved.

	3 # Use of this source code is governed by a BSD-style license that can be

	4 # found in the LICENSE file.

	5

	6 """

	7 check_no_neon.py - Check modules do not contain ARM Neon instructions.

	8 """

	9

	10 import os

	11 import sys

	12

	13 def main():

	14 if len(sys.argv) != 3:
	jbudorick 2016/07/19 18:49:16 nit: if you keep this script, please use argparse. nit: if you keep this script, please use argparse. pauljensen 2016/07/20 15:04:37 Done. Show quoted text On 2016/07/19 18:49:16, jbudorick wrote: > nit: if you keep this script, please use argparse. Done.
	15 print 'Usage: ' + os.path.basename(sys.argv[0]) + \

	16 ' path/to/ARM/objdump files/to/check/*.o'

	17 return 1

	18 return os.system(sys.argv[1] + ' -d --no-show-raw-insn ' +

	19 sys.argv[2] + ' \| grep -q "vld[1-9]\\\|vst[1-9]"')

	20

	21 if __name__ == '__main__':

	22 sys.exit(0 if main() != 0 else -1)

OLD	NEW

« components/cronet/android/BUILD.gn ('K') | « components/cronet/android/BUILD.gn ('k') | components/cronet/tools/cr_cronet.py » ('j') | tools/mb/mb_config.pyl » ('J')