Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Side by Side Diff: components/cronet/android/BUILD.gn

Issue 2060333002: [Cronet] Enforce ARMv7 Cronet doesn't inadvertently use ARM Neon instructions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 import("//build/config/android/rules.gni") 7 import("//build/config/android/rules.gni")
8 import("//build/util/version.gni") 8 import("//build/util/version.gni")
9 import("//chrome/version.gni") 9 import("//chrome/version.gni")
10 import("//testing/test.gni") 10 import("//testing/test.gni")
(...skipping 827 matching lines...) Expand 10 before | Expand all | Expand 10 after
838 rebase_path(depfile, root_build_dir), 838 rebase_path(depfile, root_build_dir),
839 "--lib-java-dir", 839 "--lib-java-dir",
840 rebase_path("$root_build_dir/lib.java/components/cronet/android", 840 rebase_path("$root_build_dir/lib.java/components/cronet/android",
841 root_build_dir), 841 root_build_dir),
842 ] 842 ]
843 deps = [ 843 deps = [
844 ":cronet_javadoc_classpath", 844 ":cronet_javadoc_classpath",
845 ] 845 ]
846 } 846 }
847 847
848 action("enforce_no_neon") {
849 script = "//components/cronet/tools/check_no_neon.py"
850 args = [
851 rebase_path("${android_tool_prefix}objdump", root_build_dir),
852
853 # libcronet.so may contain ARM Neon instructions from BoringSSL, but these
854 # are only used after checking whether the CPU supports NEON at runtime,
855 # so instead check base/ as it represents a large swath of code that only
856 # contains Neon instructions when Neon is enabled by default.
857 rebase_path("$root_out_dir/obj/base/base/*.o", root_build_dir),
858 ]
859 outputs = [
860 "$root_out_dir/cronet_$target_name.d",
861 ]
862 deps = [
863 "//base:base",
864 ]
865 }
866
848 copy("cronet_package_copy") { 867 copy("cronet_package_copy") {
849 sources = [ 868 sources = [
850 "$root_out_dir/lib.java/components/cronet/android/cronet_api.jar", 869 "$root_out_dir/lib.java/components/cronet/android/cronet_api.jar",
851 "//AUTHORS", 870 "//AUTHORS",
852 "//chrome/VERSION", 871 "//chrome/VERSION",
853 "//components/cronet/android/proguard.cfg", 872 "//components/cronet/android/proguard.cfg",
854 ] 873 ]
855 outputs = [ 874 outputs = [
856 "$_package_dir/{{source_file_part}}", 875 "$_package_dir/{{source_file_part}}",
857 ] 876 ]
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
890 ":cronet_package_copy", 909 ":cronet_package_copy",
891 ":cronet_package_copy_native_lib", 910 ":cronet_package_copy_native_lib",
892 ":cronet_package_copy_native_lib_unstripped", 911 ":cronet_package_copy_native_lib_unstripped",
893 ":generate_javadoc", 912 ":generate_javadoc",
894 ":generate_licenses", 913 ":generate_licenses",
895 ":jar_cronet_api_source", 914 ":jar_cronet_api_source",
896 ":jar_cronet_other_source", 915 ":jar_cronet_other_source",
897 ":jar_cronet_sample_source", 916 ":jar_cronet_sample_source",
898 ":repackage_extracted_jars", 917 ":repackage_extracted_jars",
899 ] 918 ]
919 if (current_cpu == "arm" && arm_version == 7) {
920 deps += [ ":enforce_no_neon" ]
921 }
900 } 922 }
OLDNEW
« no previous file with comments | « no previous file | components/cronet/tools/check_no_neon.py » ('j') | components/cronet/tools/check_no_neon.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698