Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 206033004: Unguard Shadow DOM features. (Closed)

Created:
6 years, 9 months ago by hayato
Modified:
6 years, 9 months ago
Reviewers:
esprehn, dglazkov
CC:
blink-reviews, adamk+blink_chromium.org, arv+blink, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, Inactive, darktears, rune+blink, watchdog-blink-watchlist_google.com, rwlbuis
Visibility:
Public.

Description

Unguard Shadow DOM features. Runtime ShadowDOM flag was already set to true at r169201. This change shouldn't have any effects. CSSSelector still uses this flag. I'll clean up CSSSelector in another patch. BUG=336121 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169912

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -16 lines) Patch
M Source/core/css/CSSGrammar.y View 1 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSSelector.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/dom/Text.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ShadowRoot.idl View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/Event.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/EventPath.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Window.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLShadowElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
hayato
PTAL.
6 years, 9 months ago (2014-03-25 03:00:23 UTC) #1
esprehn
lgtm, btw ::-webkit-distributed() and some other stuff like custom pseudo still exists, when are we ...
6 years, 9 months ago (2014-03-25 03:01:30 UTC) #2
hayato
On 2014/03/25 03:01:30, esprehn wrote: > lgtm, btw ::-webkit-distributed() and some other stuff like custom ...
6 years, 9 months ago (2014-03-25 05:52:14 UTC) #3
hayato
The CQ bit was checked by hayato@chromium.org
6 years, 9 months ago (2014-03-25 05:52:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/206033004/20001
6 years, 9 months ago (2014-03-25 05:52:48 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 05:53:06 UTC) #6
Message was sent while issue was closed.
Change committed as 169912

Powered by Google App Engine
This is Rietveld 408576698