Navigation throttle for the Safe Browsing Subresource Filter.

components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h

Index: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h
diff --git a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h
index 29a7e73d22e7fb92f6ef44911b5ccbdde2575381..110d044ee74e24887abb1a85629e6b2e47ee7299 100644
--- a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h
+++ b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h
@@ -49,19 +49,26 @@ class ContentSubresourceFilterDriverFactory
       const GURL& url,
       const std::vector<GURL>& redirect_urls,
       safe_browsing::ThreatPatternType threat_type);

[battre, 2016/07/01 15:51:36]

When is this called? What does it do?

-  const OriginSet& activation_set() { return activate_on_origins_; }
-  bool ShouldActivateForURL(const GURL& url);
+  const OriginSet& activation_set() const { return activate_on_origins_; }

[battre, 2016/07/01 15:51:36]

What is an activation set?

Do you want to expose this? The Test can access it via the testing anyway,
right?

+  bool ShouldActivateForURL(const GURL& url) const;

[battre, 2016/07/01 15:51:35]

Who determines this?

Should this be called "InActivationSet"? "ShouldActivate" grammatically lacks an
object. Should activate what?

+  void AddOriginOfURLToActivationSet(const GURL& url);
+
+  ContentSubresourceFilterDriver* DriverFromFrameHost(
+      content::RenderFrameHost* render_frame_host);
 
  private:
+  friend class SubresourceFilterNavigationThrottleTest;
+
   typedef std::map<content::RenderFrameHost*,
                    std::unique_ptr<ContentSubresourceFilterDriver>>
       FrameHostToOwnedDriverMap;
 
+  void SetDriverForFrameHostForTesting(
+      content::RenderFrameHost* render_frame_host,
+      std::unique_ptr<ContentSubresourceFilterDriver> driver);
+
   void CreateDriverForFrameHostIfNeeded(
       content::RenderFrameHost* render_frame_host);
-  ContentSubresourceFilterDriver* DriverFromFrameHost(
-      content::RenderFrameHost* render_frame_host);
-
   // content::WebContentsObserver:
   void RenderFrameCreated(content::RenderFrameHost* render_frame_host) override;
   void RenderFrameDeleted(content::RenderFrameHost* render_frame_host) override;