Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2060313002: Navigation throttle for the Safe Browsing Subresource Filter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pre-tab-activation
Patch Set: clamy@ comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome_browser.gypi » ('j') | components/components_tests.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 194653ce9f0e0124b5171b5b26cd4b0b24945311..9793e8bdbfb730a34b834f3914fb031ae5c2388a 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -132,6 +132,7 @@
#include "components/security_interstitials/core/ssl_error_ui.h"
#include "components/signin/core/common/profile_management_switches.h"
#include "components/startup_metric_utils/browser/startup_metric_host_impl.h"
+#include "components/subresource_filter/content/browser/subresource_filter_navigation_throttle.h"
#include "components/translate/core/common/translate_switches.h"
#include "components/url_formatter/url_fixer.h"
#include "components/variations/variations_associated_data.h"
@@ -2939,6 +2940,15 @@ ChromeContentBrowserClient::CreateThrottlesForNavigation(
throttles.push_back(new extensions::ExtensionNavigationThrottle(handle));
#endif
+ if (handle->IsInMainFrame() && handle->GetURL().SchemeIsHTTPOrHTTPS()) {
+ // TODO(melandory): Activation logic should be moved to the
+ // WebContentsObserver, once ReadyToCommitNavigation is available on
+ // pre-PlzNavigate world (tracking bug: https://crbug.com/621856).
+ throttles.push_back(
+ subresource_filter::SubresourceFilterNavigationThrottle::Create(
+ handle));
+ }
+
return throttles;
}
« no previous file with comments | « no previous file | chrome/chrome_browser.gypi » ('j') | components/components_tests.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698