Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1382)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2060313002: Navigation throttle for the Safe Browsing Subresource Filter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pre-tab-activation
Patch Set: comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 672c60fc5b862d1be951c55bf76b6cdf8f92c7b3..35db5918b226e9b871ebfe5b602a0bdc56127771 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -132,6 +132,7 @@
#include "components/security_interstitials/core/ssl_error_ui.h"
#include "components/signin/core/common/profile_management_switches.h"
#include "components/startup_metric_utils/browser/startup_metric_host_impl.h"
+#include "components/subresource_filter/content/browser/subresource_filter_navigation_throttle.h"
#include "components/translate/core/common/translate_switches.h"
#include "components/url_formatter/url_fixer.h"
#include "components/variations/variations_associated_data.h"
@@ -2900,6 +2901,15 @@ ChromeContentBrowserClient::CreateThrottlesForNavigation(
throttles.push_back(new extensions::ExtensionNavigationThrottle(handle));
#endif
+ if (handle->IsInMainFrame() && handle->GetURL().SchemeIsHTTPOrHTTPS()) {
+ // TODO(melandory): Activation logic should be moved to the
+ // WebContentsObserver, once ReadyToCommitNavigation is available on
+ // pre-PlzNavigate world (tracking bug: crbug.com/621856).
nasko 2016/06/28 22:12:36 nit: https://crbug...
melandory 2016/07/01 07:10:48 Done.
+ throttles.push_back(
+ subresource_filter::SubresourceFilterNavigationThrottle::Create(
+ handle));
+ }
+
return throttles;
}

Powered by Google App Engine
This is Rietveld 408576698