Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2240)

Unified Diff: content/public/browser/navigation_handle.h

Issue 2060313002: Navigation throttle for the Safe Browsing Subresource Filter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pre-tab-activation
Patch Set: Comment to SubresourceFilterNavigationThrotle explaining its purpose. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/navigation_handle.h
diff --git a/content/public/browser/navigation_handle.h b/content/public/browser/navigation_handle.h
index 24a500ff82b6d3859511ed8ea76a99b5f228291f..adecc943e5c4aa4deb6142da1360873fbb26056f 100644
--- a/content/public/browser/navigation_handle.h
+++ b/content/public/browser/navigation_handle.h
@@ -125,7 +125,9 @@ class CONTENT_EXPORT NavigationHandle {
virtual net::Error GetNetErrorCode() = 0;
// Returns the RenderFrameHost this navigation is taking place in. This can
- // only be accessed after the navigation is ready to commit.
+ // only be accessed after the navigation starts processing the response.
+ // The RenderFrameHost returned back might not be the final one, if method is
clamy 2016/06/24 12:13:38 So 2 things here: With PlzNavigate this is the fin
melandory 2016/06/25 01:46:10 Done.
+ // called before ReadyToCommitNavigation is dispatched.
virtual RenderFrameHost* GetRenderFrameHost() = 0;
// Whether the navigation happened in the same page. This is only known
@@ -187,6 +189,10 @@ class CONTENT_EXPORT NavigationHandle {
const GURL& new_referrer_url,
bool new_is_external_protocol) = 0;
+ // Simulates that throttle is about to process the response.
+ virtual NavigationThrottle::ThrottleCheckResult
+ CallWillProcessResponseForTesting(RenderFrameHost* render_frame_host) = 0;
+
// The NavigationData that the embedder returned from
// ResourceDispatcherHostDelegate::GetNavigationData during commit. This will
// be a clone of the NavigationData.

Powered by Google App Engine
This is Rietveld 408576698