Navigation throttle for the Safe Browsing Subresource Filter.

components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

Index: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
diff --git a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
index aec0b81d45c34b6a46b2514b98a008285002e338..ed142fcfc69013d83a30dacde1c8086d91ab2ab7 100644
--- a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
+++ b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
@@ -63,9 +63,9 @@ void ContentSubresourceFilterDriverFactory::
         safe_browsing::ThreatPatternType threat_type) {
   if (threat_type != safe_browsing::ThreatPatternType::SOCIAL_ENGINEERING_ADS)
     return;
-  activate_on_origins_.insert(url.host());
+  AddToSocEngList(url);
   for (const auto& url : redirect_urls) {

[engedy, 2016/06/23 22:34:17]

nit: No {} needed.

[melandory, 2016/06/25 01:46:07]

Done.

-    activate_on_origins_.insert(url.host());
+    AddToSocEngList(url);
   }
 }
 
@@ -74,6 +74,16 @@ bool ContentSubresourceFilterDriverFactory::ShouldActivateForURL(
   return activation_set().find(url.host()) != activation_set().end();
 }
 
+void ContentSubresourceFilterDriverFactory::AddToSocEngList(const GURL& url) {
+  activate_on_origins_.insert(url.host());
+}
+
+void ContentSubresourceFilterDriverFactory::TestingSetDriverForFrame(
+    content::RenderFrameHost* render_frame_host,
+    std::unique_ptr<ContentSubresourceFilterDriver> driver) {
+  frame_drivers_.insert(std::make_pair(render_frame_host, std::move(driver)));

[engedy, 2016/06/23 22:34:17]

Note that this is somewhat fragile in the sense that if a driver was already
there, it will not be overwritten, instead the passed in |driver| is just
destroyed.

Could you please either add a comment to give warning of this to the header, or
use the approach from lines 51--56?

[melandory, 2016/06/25 01:46:07]

Done.

+}
+
 ContentSubresourceFilterDriver*
 ContentSubresourceFilterDriverFactory::DriverFromFrameHost(
     content::RenderFrameHost* render_frame_host) {