components/subresource_filter/content/browser/BUILD.gn - Issue 2060313002: Navigation throttle for the Safe Browsing Subresource Filter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/browser/BUILD.gn

Issue 2060313002: Navigation throttle for the Safe Browsing Subresource Filter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pre-tab-activation

Patch Set: Comment to SubresourceFilterNavigationThrotle explaining its purpose. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chrome_content_browser_client.cc ('K') | « components/subresource_filter.gypi ('k') | components/subresource_filter/content/browser/content_subresource_filter_driver.h » ('j') | components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/browser/BUILD.gn

diff --git a/components/subresource_filter/content/browser/BUILD.gn b/components/subresource_filter/content/browser/BUILD.gn

index f196665c38c9e05ff70ae1cf97f7877dfb01d96a..9791101b0d2fb0b050be92ceaf9a0f8f400be93c 100644

--- a/components/subresource_filter/content/browser/BUILD.gn

+++ b/components/subresource_filter/content/browser/BUILD.gn

@@ -10,6 +10,8 @@ source_set("browser") {

"content_subresource_filter_driver.h",

"content_subresource_filter_driver_factory.cc",

"content_subresource_filter_driver_factory.h",

+ "subresource_filter_navigation_throttle.cc",

+ "subresource_filter_navigation_throttle.h",

]

deps = [

"//base",

@@ -29,12 +31,15 @@ source_set("unit_tests") {

sources = [

"content_ruleset_distributor_unittest.cc",

"content_subresource_filter_driver_factory_unittest.cc",

+ "subresource_filter_navigation_throttle_unittests.cc",

engedy 2016/06/23 22:34:17 Don't forget to add this to components_tests.gyp,

melandory 2016/06/25 01:46:06 Done.

]

deps = [

":browser",

"//base/test:test_support",

"//components/safe_browsing_db:util",

"//components/subresource_filter/content/common",

+ "//components/subresource_filter/core/browser:browser",

engedy 2016/06/23 22:34:17 nit: You may just write: "//components/subresourc

melandory 2016/06/25 01:46:05 Done.

+ "//components/subresource_filter/core/browser:test_support",

"//content/test:test_support",

"//ipc",

"//ipc:test_support",