Issue 206030: disable extension bar for now

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 206030: disable extension bar for now (Closed)

Created:
11 years, 3 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

disable extension bar for now BUG=none TEST=extension bar is no longer visible Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26352

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -9 lines)			Patch
	M	chrome/browser/cocoa/browser_window_controller.mm	View		1 chunk	+11 lines, -9 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

I will turn it back on when a) it only shows up when you have ...

11 years, 3 months ago (2009-09-16 15:38:08 UTC) #1

pink (ping after 24hrs)

11 years, 3 months ago (2009-09-16 16:21:56 UTC) #2

LGTM with #if 0

http://codereview.chromium.org/206030/diff/1/2
File chrome/browser/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/206030/diff/1/2#newcode195
Line 195: //    if
(browser_->SupportsWindowFeature(Browser::FEATURE_EXTENSIONSHELF)) {
this should be #if 0 rather than commenting out each individual line.

Expand Messages | Collapse Messages