Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2060283002: Inspect local variables and fields from service protocol. (Closed)

Created:
4 years, 6 months ago by sigurdm
Modified:
4 years, 6 months ago
Reviewers:
Søren Gjesse
CC:
dartino-code-reviews_googlegroups.com, danrubel
Base URL:
git@github.com:dartino/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Inspect local variables and fields from service protocol. BUG= R=sgjesse@google.com Committed: https://github.com/dartino/sdk/commit/66342e53abec9bdd69402b225d922f48a397985e

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 6

Patch Set 3 : Address review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -63 lines) Patch
M pkg/dartino_compiler/lib/src/debug_service_protocol.dart View 1 2 15 chunks +177 lines, -63 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
sigurdm
This CL depends on https://codereview.chromium.org/2065933004/.
4 years, 6 months ago (2016-06-15 09:20:42 UTC) #4
Søren Gjesse
lgtm https://codereview.chromium.org/2060283002/diff/60001/pkg/dartino_compiler/lib/src/debug_service_protocol.dart File pkg/dartino_compiler/lib/src/debug_service_protocol.dart (right): https://codereview.chromium.org/2060283002/diff/60001/pkg/dartino_compiler/lib/src/debug_service_protocol.dart#newcode143 pkg/dartino_compiler/lib/src/debug_service_protocol.dart:143: print("Adding ${vars.last}"); Debug print. https://codereview.chromium.org/2060283002/diff/60001/pkg/dartino_compiler/lib/src/debug_service_protocol.dart#newcode383 pkg/dartino_compiler/lib/src/debug_service_protocol.dart:383: print("classId $classId ...
4 years, 6 months ago (2016-06-15 11:26:18 UTC) #5
sigurdm
Committed patchset #2 (id:60001) manually as 66342e53abec9bdd69402b225d922f48a397985e (presubmit successful).
4 years, 6 months ago (2016-06-16 10:51:55 UTC) #7
sigurdm
4 years, 6 months ago (2016-06-17 07:29:32 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/2060283002/diff/60001/pkg/dartino_compiler/li...
File pkg/dartino_compiler/lib/src/debug_service_protocol.dart (right):

https://codereview.chromium.org/2060283002/diff/60001/pkg/dartino_compiler/li...
pkg/dartino_compiler/lib/src/debug_service_protocol.dart:143: print("Adding
${vars.last}");
On 2016/06/15 11:26:18, Søren Gjesse wrote:
> Debug print.

Done.

https://codereview.chromium.org/2060283002/diff/60001/pkg/dartino_compiler/li...
pkg/dartino_compiler/lib/src/debug_service_protocol.dart:383: print("classId
$classId element $classElement");
On 2016/06/15 11:26:18, Søren Gjesse wrote:
> Debug print.

Done.

https://codereview.chromium.org/2060283002/diff/60001/pkg/dartino_compiler/li...
pkg/dartino_compiler/lib/src/debug_service_protocol.dart:437: } else if
(remoteObject is RemoteArray) {
On 2016/06/15 11:26:18, Søren Gjesse wrote:
> Probably want to have a TODO on handling large arrays, so that only part of
the
> elements are transferred initially, and then can be fetched on demand.
Added TODO.
> 
> Does the protocol support the concept of partial arrays?
It does - I don't know the details of how it works though.

Powered by Google App Engine
This is Rietveld 408576698