Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2060273004:
Fix asserts to account for the fact that SVG may have contains: paint. (Closed)
|
Created:
4 years, 6 months ago by chrishtr Modified:
4 years, 6 months ago CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1 Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix asserts to account for the fact that SVG may have contains: paint.
BUG=619032
Committed: https://crrev.com/73a56783feab40c659c22a4e2d664f20b9e06198
Cr-Commit-Position: refs/heads/master@{#399658}
Patch Set 1 #Patch Set 2 : none #
Total comments: 4
Patch Set 3 : none #Messages
Total messages: 18 (8 generated)
Description was changed from ========== none none BUG= ========== to ========== Fix asserts to account for the fact that SVG may have contains: paint. BUG=619032 ==========
chrishtr@chromium.org changed reviewers: + fs@opera.com
LGTM w/ suggested clarification of comment https://codereview.chromium.org/2060273004/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp (right): https://codereview.chromium.org/2060273004/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp:52: // Having clip or overflow clip forces the LayoutObject to become a layer, except for contains: paint, which may apply to SVG. "...which may apply to SVG elements without forcing a layer. (SVG elements in general cannot have PaintLayers.)" Maybe?
pdr@chromium.org changed reviewers: + pdr@chromium.org
LGTM 2 https://codereview.chromium.org/2060273004/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp (right): https://codereview.chromium.org/2060273004/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp:53: // SVG cannot have PaintLayers. It may be useful to clarify that this PaintLayer restriction doesn't apply to the root, which can have a paint layer.
https://codereview.chromium.org/2060273004/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp (right): https://codereview.chromium.org/2060273004/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp:52: // Having clip or overflow clip forces the LayoutObject to become a layer, except for contains: paint, which may apply to SVG. On 2016/06/13 at 20:03:56, fs wrote: > "...which may apply to SVG elements without forcing a layer. (SVG elements in general cannot have PaintLayers.)" > > Maybe? Done. https://codereview.chromium.org/2060273004/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp:53: // SVG cannot have PaintLayers. On 2016/06/13 at 20:05:51, pdr. wrote: > It may be useful to clarify that this PaintLayer restriction doesn't apply to the root, which can have a paint layer. Done.
The CQ bit was checked by chrishtr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org, fs@opera.com Link to the patchset: https://codereview.chromium.org/2060273004/#ps40001 (title: "none")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060273004/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by chrishtr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060273004/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
CQ bit was unchecked
Message was sent while issue was closed.
Description was changed from ========== Fix asserts to account for the fact that SVG may have contains: paint. BUG=619032 ========== to ========== Fix asserts to account for the fact that SVG may have contains: paint. BUG=619032 Committed: https://crrev.com/73a56783feab40c659c22a4e2d664f20b9e06198 Cr-Commit-Position: refs/heads/master@{#399658} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/73a56783feab40c659c22a4e2d664f20b9e06198 Cr-Commit-Position: refs/heads/master@{#399658} |
