Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2060273003:
[tests] Don't test moves between different reps in test-gap-resolver.cc (Closed)
Description[tests] Don't test moves between different reps in test-gap-resolver.cc
Moves between operands with different representations shouldn't happen,
so don't test them. This makes it easier to modify canonicalization to
differentiate between floating point types, which is needed to support
floating point register aliasing for ARM and MIPS.
This change also expands tests to include explicit FP moves (both register and stack slot).
LOG=N
BUG=v8:4124
Committed: https://crrev.com/fc59eb8a7a1eb45edd2d4ff7910e66fab3093030
Cr-Commit-Position: refs/heads/master@{#36963}
Patch Set 1 #
Messages
Total messages: 19 (10 generated)
bbudge@chromium.org changed reviewers: + mtrofin@chromium.org
On 2016/06/13 21:31:10, bbudge wrote: lgtm
The CQ bit was checked by bbudge@chromium.org
The CQ bit was unchecked by bbudge@chromium.org
The CQ bit was checked by bbudge@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060273003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/17118)
bbudge@chromium.org changed reviewers: + bmeurer@chromium.org
+Benedikt for OWNERs
Description was changed from ========== [tests] Don't test moves between different reps in test-gap-resolver.cc Moves between operands with different representations shouldn't happen, so don't test them. This makes it easier to modify canonicalization to differentiate between floating point types, which is needed to support floating point register aliasing for ARM and MIPS. LOG=N BUG=v8:4124 ========== to ========== [tests] Don't test moves between different reps in test-gap-resolver.cc Moves between operands with different representations shouldn't happen, so don't test them. This makes it easier to modify canonicalization to differentiate between floating point types, which is needed to support floating point register aliasing for ARM and MIPS. This change also expands tests to include explicit FP moves (both register and stack slot). LOG=N BUG=v8:4124 ==========
lgtm
The CQ bit was checked by bbudge@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060273003/1
Message was sent while issue was closed.
Description was changed from ========== [tests] Don't test moves between different reps in test-gap-resolver.cc Moves between operands with different representations shouldn't happen, so don't test them. This makes it easier to modify canonicalization to differentiate between floating point types, which is needed to support floating point register aliasing for ARM and MIPS. This change also expands tests to include explicit FP moves (both register and stack slot). LOG=N BUG=v8:4124 ========== to ========== [tests] Don't test moves between different reps in test-gap-resolver.cc Moves between operands with different representations shouldn't happen, so don't test them. This makes it easier to modify canonicalization to differentiate between floating point types, which is needed to support floating point register aliasing for ARM and MIPS. This change also expands tests to include explicit FP moves (both register and stack slot). LOG=N BUG=v8:4124 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [tests] Don't test moves between different reps in test-gap-resolver.cc Moves between operands with different representations shouldn't happen, so don't test them. This makes it easier to modify canonicalization to differentiate between floating point types, which is needed to support floating point register aliasing for ARM and MIPS. This change also expands tests to include explicit FP moves (both register and stack slot). LOG=N BUG=v8:4124 ========== to ========== [tests] Don't test moves between different reps in test-gap-resolver.cc Moves between operands with different representations shouldn't happen, so don't test them. This makes it easier to modify canonicalization to differentiate between floating point types, which is needed to support floating point register aliasing for ARM and MIPS. This change also expands tests to include explicit FP moves (both register and stack slot). LOG=N BUG=v8:4124 Committed: https://crrev.com/fc59eb8a7a1eb45edd2d4ff7910e66fab3093030 Cr-Commit-Position: refs/heads/master@{#36963} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/fc59eb8a7a1eb45edd2d4ff7910e66fab3093030 Cr-Commit-Position: refs/heads/master@{#36963} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
