[GN] Add support for code signing to "create_bundle" targets.

[GN] Add support for code signing to "create_bundle" targets.

To be able to run iOS application on device, they have to be code signed.
The code signature needs all the files to have been copied in the bundle
(as it embeds a manifest) and embeds the signature in the binary. This
prevents running the code signature as a separate action (as it either
run before the file have been copied into the bundle, or it modify the
output of another target).

This CL adds support for running a script to perform the code signing as
the last step of creating the application bundle. If a script is defined,
it is run after all files have been copied into the bundle. The script can
add new file in the bundle but must not modify any file already there (on
iOS this means that the script will copy the binary into the bundle).

While adding support for code signing, found and fixed an issue where the
input dependencies of the create_bundle targets was incorrect (files that
are not generated were not listed as inputs).

BUG=600491
Committed: https://crrev.com/14ddbb64afb087115791aeb2237dc880eac6de12
Cr-Commit-Position: refs/heads/master@{#399755}

[sdefresne, 2016-06-13 14:34:13]

sdefresne@chromium.org changed reviewers:
+ brettw@chromium.org

[sdefresne, 2016-06-13 14:34:13]

Please take a look.

[sdefresne, 2016-06-13 16:37:49]

On 2016/06/13 14:34:13, sdefresne wrote:
> Please take a look.

This is how it will be used: https://codereview.chromium.org/2060943002/

[brettw, 2016-06-13 21:16:27]

My recollection is that there are multiple bundle_data targets all over that get
combined into a final bundle in a create_bundle.

In this system, I don't understand how putting the code signing script on the
bundle data target makes sense. What am I missing?

[sdefresne, 2016-06-14 07:34:01]

On 2016/06/13 21:16:27, brettw wrote:
> My recollection is that there are multiple bundle_data targets all over that
get
> combined into a final bundle in a create_bundle.
> 
> In this system, I don't understand how putting the code signing script on the
> bundle data target makes sense. What am I missing?

Bundle supports uses two types of targets:
 - "bundle_data" lists file that needs to be copied in a bundle, and their
location,
 - "create_bundle" copies the files into the bundle.

I agree that it would not make sense to add code signing to the "bundle_data"
targets, however my CL add it to the other kind of target, i.e. to
"create_bundle". There is generally one instance of "create_bundle" target per
application or application extension on iOS and all of them need to be code
signed.

Is it clearer now? If so, could you take a look at the CL?

[sdefresne, 2016-06-14 07:37:10]

On 2016/06/14 07:34:01, sdefresne wrote:
> On 2016/06/13 21:16:27, brettw wrote:
> > My recollection is that there are multiple bundle_data targets all over that
> get
> > combined into a final bundle in a create_bundle.
> > 
> > In this system, I don't understand how putting the code signing script on
the
> > bundle data target makes sense. What am I missing?
> 
> Bundle supports uses two types of targets:
>  - "bundle_data" lists file that needs to be copied in a bundle, and their
> location,
>  - "create_bundle" copies the files into the bundle.
> 
> I agree that it would not make sense to add code signing to the "bundle_data"
> targets, however my CL add it to the other kind of target, i.e. to
> "create_bundle". There is generally one instance of "create_bundle" target per
> application or application extension on iOS and all of them need to be code
> signed.
> 
> Is it clearer now? If so, could you take a look at the CL?

The confusion may come from the fact that I'm adding the code signing
information to the BundleData object. There is one such object per Target, but
they are not used (except to propagate dependencies) except if the target
output_type is Target::CREATE_BUNDLE. It is unfortunate that this class has the
same name as the "bundle_data" target but serve a different purpose (hold the
values for "create_bundle" targets).

[brettw, 2016-06-14 17:36:26]

Yes, that explains my confusion. LGTM

https://codereview.chromium.org/2060273002/diff/80001/tools/gn/variables.cc
File tools/gn/variables.cc (right):

https://codereview.chromium.org/2060273002/diff/80001/tools/gn/variables.cc#n...
tools/gn/variables.cc:678: "code_signing_sources: [file list] Sources for code
signing step.\n";
No \n at end of this line.

https://codereview.chromium.org/2060273002/diff/80001/tools/gn/variables.cc#n...
tools/gn/variables.cc:690: "code_signing_outputs: [file list] Output files for
code signing step.\n";
No \n

[sdefresne, 2016-06-14 17:50:16]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-06-14 17:50:16]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2060273002/#ps100001
(title: "Remove superfluous \n")

[commit-bot: I haz the power, 2016-06-14 17:51:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2060273002/100001

[commit-bot: I haz the power, 2016-06-14 18:33:44]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-14 18:34:05]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-14 18:34:59]

Description was changed from

==========
[GN] Add support for code signing to "create_bundle" targets.

To be able to run iOS application on device, they have to be code signed.
The code signature needs all the files to have been copied in the bundle
(as it embeds a manifest) and embeds the signature in the binary. This
prevents running the code signature as a separate action (as it either
run before the file have been copied into the bundle, or it modify the
output of another target).

This CL adds support for running a script to perform the code signing as
the last step of creating the application bundle. If a script is defined,
it is run after all files have been copied into the bundle. The script can
add new file in the bundle but must not modify any file already there (on
iOS this means that the script will copy the binary into the bundle).

While adding support for code signing, found and fixed an issue where the
input dependencies of the create_bundle targets was incorrect (files that
are not generated were not listed as inputs).

BUG=600491
==========

to

==========
[GN] Add support for code signing to "create_bundle" targets.

To be able to run iOS application on device, they have to be code signed.
The code signature needs all the files to have been copied in the bundle
(as it embeds a manifest) and embeds the signature in the binary. This
prevents running the code signature as a separate action (as it either
run before the file have been copied into the bundle, or it modify the
output of another target).

This CL adds support for running a script to perform the code signing as
the last step of creating the application bundle. If a script is defined,
it is run after all files have been copied into the bundle. The script can
add new file in the bundle but must not modify any file already there (on
iOS this means that the script will copy the binary into the bundle).

While adding support for code signing, found and fixed an issue where the
input dependencies of the create_bundle targets was incorrect (files that
are not generated were not listed as inputs).

BUG=600491

Committed: https://crrev.com/14ddbb64afb087115791aeb2237dc880eac6de12
Cr-Commit-Position: refs/heads/master@{#399755}
==========

[commit-bot: I haz the power, 2016-06-14 18:35:00]

Patchset 6 (id:??) landed as
https://crrev.com/14ddbb64afb087115791aeb2237dc880eac6de12
Cr-Commit-Position: refs/heads/master@{#399755}