Deprecate FileUriResolver and RelativeFileUriResolver in source_io.dart, replace the usages with Re…

Deprecate FileUriResolver and RelativeFileUriResolver in source_io.dart, replace the usages with ResourceUriResolver(PhysicalResourceProvider.INSTANCE).

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/7f244c8d3939968f159da4f4e692e199bf2d9256

[jwren, 2016-06-16 17:19:54]

jwren@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-06-16 17:39:30]

lgtm

https://codereview.chromium.org/2060263006/diff/1/pkg/analyzer/lib/file_syste...
File pkg/analyzer/lib/file_system/file_system.dart (right):

https://codereview.chromium.org/2060263006/diff/1/pkg/analyzer/lib/file_syste...
pkg/analyzer/lib/file_system/file_system.dart:222: static String FILE_SCHEME =
"file";
This should be marked 'final' now that it's public.

https://codereview.chromium.org/2060263006/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/all_the_rest_test.dart (right):

https://codereview.chromium.org/2060263006/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/all_the_rest_test.dart:4313: new
ResourceUriResolver(PhysicalResourceProvider.INSTANCE), isNotNull);
This is no longer testing FileUriResolver. I think we should revert these tests.
They'll be removed when FileUriResolver is removed. (I'm assuming that all of
these tests are covered in ResourceUriResolverTest. If not, they should be
copied there.)

[jwren, 2016-06-16 18:09:56]

https://codereview.chromium.org/2060263006/diff/1/pkg/analyzer/lib/file_syste...
File pkg/analyzer/lib/file_system/file_system.dart (right):

https://codereview.chromium.org/2060263006/diff/1/pkg/analyzer/lib/file_syste...
pkg/analyzer/lib/file_system/file_system.dart:222: static String FILE_SCHEME =
"file";
On 2016/06/16 17:39:30, Brian Wilkerson wrote:
> This should be marked 'final' now that it's public.

Done.

https://codereview.chromium.org/2060263006/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/all_the_rest_test.dart (right):

https://codereview.chromium.org/2060263006/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/all_the_rest_test.dart:4313: new
ResourceUriResolver(PhysicalResourceProvider.INSTANCE), isNotNull);
On 2016/06/16 17:39:30, Brian Wilkerson wrote:
> This is no longer testing FileUriResolver. I think we should revert these
tests.
> They'll be removed when FileUriResolver is removed. (I'm assuming that all of
> these tests are covered in ResourceUriResolverTest. If not, they should be
> copied there.)

Done.

[jwren, 2016-06-16 18:14:08]

Description was changed from

==========
Deprecate FileUriResolver and RelativeFileUriResolver in source_io.dart, replace
the usages with ResourceUriResolver(PhysicalResourceProvider.INSTANCE).
==========

to

==========
Deprecate FileUriResolver and RelativeFileUriResolver in source_io.dart, replace
the usages with ResourceUriResolver(PhysicalResourceProvider.INSTANCE).

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7f244c8d3939968f159da4f4e692e199bf2d9256
==========

[jwren, 2016-06-16 18:14:10]

Committed patchset #1 (id:1) manually as
7f244c8d3939968f159da4f4e692e199bf2d9256 (presubmit successful).