src/compiler/arm64/code-generator-arm64.cc - Issue 2060233002: [turbofan] Prevent storing signalling NaNs into holey double arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/arm64/code-generator-arm64.cc

Issue 2060233002: [turbofan] Prevent storing signalling NaNs into holey double arrays. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/arm64/code-generator-arm64.cc

diff --git a/src/compiler/arm64/code-generator-arm64.cc b/src/compiler/arm64/code-generator-arm64.cc

index 51a2a7a7efd0d1fe87034a44acbfd285a757ae9d..fc31f8916cba94dd0bd70513f987a1c7372d43c4 100644

--- a/src/compiler/arm64/code-generator-arm64.cc

+++ b/src/compiler/arm64/code-generator-arm64.cc

@@ -1385,6 +1385,9 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(

case kArm64Float64MoveU64:

__ Fmov(i.OutputFloat64Register(), i.InputRegister(0));

break;

+ case kArm64Float64SilenceNaN:

+ __ CanonicalizeNaN(i.OutputDoubleRegister(), i.InputDoubleRegister(0));

+ break;

case kArm64U64MoveFloat64:

__ Fmov(i.OutputRegister(), i.InputDoubleRegister(0));

break;

« no previous file with comments | « src/compiler/arm/instruction-selector-arm.cc ('k') | src/compiler/arm64/instruction-codes-arm64.h » ('j') | src/compiler/instruction-selector.h » ('J')