Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Issue 2060223004: [Autofill] Put Autofill Profile Cleanup behing a feature flag. (Closed)

Created:
4 years, 6 months ago by Mathieu
Modified:
4 years, 6 months ago
Reviewers:
sebsg
CC:
browser-components-watch_chromium.org, chromium-reviews, estade+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, rouslan+autofill_chromium.org, vabr+watchlistautofill_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Put Autofill Profile Cleanup behing a feature flag. BUG=618356 TEST=PersonalDataManagerTest Committed: https://crrev.com/c1d083425059e8195e11e0b5d57fff2f5a1fa8d5 Cr-Commit-Position: refs/heads/master@{#399911}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix test #

Patch Set 3 : ios fix #

Patch Set 4 : ios fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -2 lines) Patch
M components/autofill/core/browser/autofill_experiments.h View 3 chunks +9 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_experiments.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_merge_unittest.cc View 1 2 3 3 chunks +8 lines, -0 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 1 5 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
Mathieu
Hi Seb, PTAL.
4 years, 6 months ago (2016-06-14 15:42:45 UTC) #2
sebsg
LGTM with the test fix. Thanks! https://codereview.chromium.org/2060223004/diff/1/components/autofill/core/browser/personal_data_manager_unittest.cc File components/autofill/core/browser/personal_data_manager_unittest.cc (right): https://codereview.chromium.org/2060223004/diff/1/components/autofill/core/browser/personal_data_manager_unittest.cc#newcode4404 components/autofill/core/browser/personal_data_manager_unittest.cc:4404: EnableAutofillProfileCleanup(); Please add ...
4 years, 6 months ago (2016-06-14 18:34:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060223004/20001
4 years, 6 months ago (2016-06-14 20:51:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/21012)
4 years, 6 months ago (2016-06-14 21:15:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060223004/20001
4 years, 6 months ago (2016-06-15 00:40:40 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/21191)
4 years, 6 months ago (2016-06-15 01:22:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060223004/20001
4 years, 6 months ago (2016-06-15 12:06:07 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060223004/60001
4 years, 6 months ago (2016-06-15 15:13:02 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-15 16:05:49 UTC) #19
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 16:05:54 UTC) #20
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 16:09:00 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c1d083425059e8195e11e0b5d57fff2f5a1fa8d5
Cr-Commit-Position: refs/heads/master@{#399911}

Powered by Google App Engine
This is Rietveld 408576698