Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: src/wasm/wasm-module.cc

Issue 2060213002: Revert of Replace all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/string-stream.cc ('k') | test/cctest/compiler/test-js-context-specialization.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/wasm-module.cc
diff --git a/src/wasm/wasm-module.cc b/src/wasm/wasm-module.cc
index 39421ab6515a09bd8df3edf0f63126ca7d0feafa..8ad95c8c1efd04cff6b9c0606be83bd0d2e63582 100644
--- a/src/wasm/wasm-module.cc
+++ b/src/wasm/wasm-module.cc
@@ -984,7 +984,7 @@
Handle<Object> GetWasmFunctionNameOrNull(Isolate* isolate, Handle<Object> wasm,
uint32_t func_index) {
- if (!wasm->IsUndefined(isolate)) {
+ if (!wasm->IsUndefined()) {
Handle<ByteArray> func_names_arr_obj(
ByteArray::cast(Handle<JSObject>::cast(wasm)->GetInternalField(
kWasmFunctionNamesArray)),
@@ -1004,9 +1004,7 @@
uint32_t func_index) {
Handle<Object> name_or_null =
GetWasmFunctionNameOrNull(isolate, wasm, func_index);
- if (!name_or_null->IsNull(isolate)) {
- return Handle<String>::cast(name_or_null);
- }
+ if (!name_or_null->IsNull()) return Handle<String>::cast(name_or_null);
return isolate->factory()->NewStringFromStaticChars("<WASM UNNAMED>");
}
« no previous file with comments | « src/string-stream.cc ('k') | test/cctest/compiler/test-js-context-specialization.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698