Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Unified Diff: test/cctest/test-field-type-tracking.cc

Issue 2060213002: Revert of Replace all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-dictionary.cc ('k') | test/cctest/test-strings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-field-type-tracking.cc
diff --git a/test/cctest/test-field-type-tracking.cc b/test/cctest/test-field-type-tracking.cc
index 33a2dac2513fe2740763b5a72e40a33482701a1f..9709f87597943c79c82f91f9c96eae082075b5ca 100644
--- a/test/cctest/test-field-type-tracking.cc
+++ b/test/cctest/test-field-type-tracking.cc
@@ -388,16 +388,16 @@
Handle<String> name = MakeName("prop", property_index);
- CHECK(!getter->IsNull(isolate_) || !setter->IsNull(isolate_));
+ CHECK(!getter->IsNull() || !setter->IsNull());
Factory* factory = isolate_->factory();
- if (!getter->IsNull(isolate_)) {
+ if (!getter->IsNull()) {
Handle<AccessorPair> pair = factory->NewAccessorPair();
pair->SetComponents(*getter, *factory->null_value());
AccessorConstantDescriptor new_desc(name, pair, attributes);
map = Map::CopyInsertDescriptor(map, &new_desc, INSERT_TRANSITION);
}
- if (!setter->IsNull(isolate_)) {
+ if (!setter->IsNull()) {
Handle<AccessorPair> pair = factory->NewAccessorPair();
pair->SetComponents(*getter, *setter);
AccessorConstantDescriptor new_desc(name, pair, attributes);
@@ -486,7 +486,7 @@
Handle<JSObject> obj = factory->NewJSObjectFromMap(map);
JSObject::MigrateToMap(obj, prepared_map);
FieldIndex index = FieldIndex::ForDescriptor(*prepared_map, 0);
- CHECK(obj->RawFastPropertyAt(index)->IsUninitialized(isolate));
+ CHECK(obj->RawFastPropertyAt(index)->IsUninitialized());
#ifdef VERIFY_HEAP
obj->ObjectVerify();
#endif
@@ -644,7 +644,7 @@
Map* tmp = *new_map;
while (true) {
Object* back = tmp->GetBackPointer();
- if (back->IsUndefined(isolate)) break;
+ if (back->IsUndefined()) break;
tmp = Map::cast(back);
CHECK(!tmp->is_stable());
}
@@ -1242,7 +1242,7 @@
CHECK(!map->is_deprecated());
CHECK_NE(*map, *new_map);
- CHECK(new_map->GetBackPointer()->IsUndefined(map->GetIsolate()));
+ CHECK(new_map->GetBackPointer()->IsUndefined());
for (int i = 0; i < kPropCount; i++) {
expectations.GeneralizeRepresentation(i);
}
@@ -1873,7 +1873,7 @@
// Try to update |map|, since there is no place for propX transition at |map2|
// |map| should become "copy-generalized".
Handle<Map> updated_map = Map::Update(map);
- CHECK(updated_map->GetBackPointer()->IsUndefined(isolate));
+ CHECK(updated_map->GetBackPointer()->IsUndefined());
for (int i = 0; i < kPropCount; i++) {
expectations.SetDataField(i, Representation::Tagged(), any_type);
@@ -1973,10 +1973,10 @@
for (int i = 0; i < kPropCount; i++) {
expectations2.GeneralizeRepresentation(i);
}
- CHECK(new_map2->GetBackPointer()->IsUndefined(isolate));
+ CHECK(new_map2->GetBackPointer()->IsUndefined());
CHECK(expectations2.Check(*new_map2));
} else {
- CHECK(!new_map2->GetBackPointer()->IsUndefined(isolate));
+ CHECK(!new_map2->GetBackPointer()->IsUndefined());
CHECK(expectations2.Check(*new_map2));
}
}
« no previous file with comments | « test/cctest/test-dictionary.cc ('k') | test/cctest/test-strings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698