Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2060213002: Revert of Replace all remaining Oddball checks with new function (Closed)

Created:
4 years, 6 months ago by Camillo Bruni
Modified:
4 years, 6 months ago
CC:
oth, rmcilroy, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Replace all remaining Oddball checks with new function (patchset #10 id:180001 of https://codereview.chromium.org/2043183003/ ) Reason for revert: failing tests Original issue's description: > Replace all remaining Oddball checks with new function > > This CL removes the IsUndefined() and Co. methods from Object and HeapObject. > The new method all take the isolate as parameter. > > BUG= > > Committed: https://crrev.com/ccefb3ae5fe967288d568013fb04e8761eafebc5 > Cr-Commit-Position: refs/heads/master@{#36921} TBR=mstarzinger@chromium.org,verwaest@chromium.org,yangguo@chromium.org,ahaas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/33b8bc24a12fb062100c0be84456faeb0b9fa5d1 Cr-Commit-Position: refs/heads/master@{#36923}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -294 lines) Patch
M src/api.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/api.cc View 12 chunks +15 lines, -31 lines 0 comments Download
M src/api-natives.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ast/ast.cc View 4 chunks +7 lines, -14 lines 0 comments Download
M src/ast/prettyprinter.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/builtins.cc View 9 chunks +10 lines, -11 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/access-info.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-call-reducer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-create-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-graph.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/hydrogen-types.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/debug.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/debug/debug-frames.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/elements.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/execution.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/futex-emulation.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/global-handles.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/handler-compiler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ic/ic.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/isolate-inl.h View 2 chunks +7 lines, -7 lines 0 comments Download
M src/json-parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/json-stringifier.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M src/log.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/lookup.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/messages.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.h View 4 chunks +20 lines, -21 lines 0 comments Download
M src/objects.cc View 13 chunks +19 lines, -22 lines 0 comments Download
M src/objects-debug.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects-inl.h View 9 chunks +33 lines, -23 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/prototype.h View 4 chunks +4 lines, -5 lines 0 comments Download
M src/regexp/regexp-macro-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-classes.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-debug.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M src/runtime/runtime-forin.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-literals.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/runtime/runtime-object.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/runtime/runtime-strings.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-typedarray.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-utils.h View 1 chunk +1 line, -1 line 0 comments Download
M src/string-stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-module.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-js-context-specialization.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M test/cctest/heap/test-alloc.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/heap/test-heap.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M test/cctest/test-api.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-dictionary.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-field-type-tracking.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Camillo Bruni
Created Revert of Replace all remaining Oddball checks with new function
4 years, 6 months ago (2016-06-13 11:39:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060213002/1
4 years, 6 months ago (2016-06-13 11:39:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 11:40:26 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/33b8bc24a12fb062100c0be84456faeb0b9fa5d1 Cr-Commit-Position: refs/heads/master@{#36923}
4 years, 6 months ago (2016-06-13 11:40:42 UTC) #6
Camillo Bruni
4 years, 6 months ago (2016-06-13 12:04:29 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2059173002/ by cbruni@chromium.org.

The reason for reverting is: Cannot reproduce gc-stress failures locally..

Powered by Google App Engine
This is Rietveld 408576698