Clear the SharedBuffer when clearing the image

Clear the SharedBuffer when clearing the image

Previously, in the case of the image failing to be decoded, the buffer
was cleared because error() was called. This was changed in the
following patch:

 https://chromium.googlesource.com/chromium/src/+/61e34ff7dd4ac48b8c4275eb3f541ebfb8a50266%5E%21/

The patch changes it so that only clear() is called, which does not
clear the m_data buffer. This patch changes clear() to also clear the
buffer.

BUG=

Committed: https://crrev.com/d6ae2381c93fcc66c72452327c0b55e79eca228f
Cr-Commit-Position: refs/heads/master@{#399668}

[robertn, 2016-06-13 10:52:49]

Description was changed from

==========
Clear the SharedBuffer when clearing the image

Previously, in the case of the image failing to be decoded, the buffer
was cleared because error() was called. This was changed in the
following patch:


https://chromium.googlesource.com/chromium/src/+/61e34ff7dd4ac48b8c4275eb3f54...

The patch changes it so that only clear() is called, which does not
clear the m_data buffer. This patch changes clear() to also clear the
buffer.

BUG=
==========

to

==========
Clear the SharedBuffer when clearing the image

Previously, in the case of the image failing to be decoded, the buffer
was cleared because error() was called. This was changed in the
following patch:


https://chromium.googlesource.com/chromium/src/+/61e34ff7dd4ac48b8c4275eb3f54...

The patch changes it so that only clear() is called, which does not
clear the m_data buffer. This patch changes clear() to also clear the
buffer.

BUG=
==========

[robertn, 2016-06-13 10:52:50]

robertn@opera.com changed reviewers:
+ japhet@chromium.org, sigbjornf@opera.com

[sof, 2016-06-13 11:15:27]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-13 11:15:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2060193002/1

[sof, 2016-06-13 11:16:22]

(started a cq dryrun.)

[commit-bot: I haz the power, 2016-06-13 14:36:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 14:36:01]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2016-06-13 16:44:27]

Oops...good catch. LGTM. Is there a bug/test associated with this?

[robertn, 2016-06-14 08:24:59]

On 2016/06/13 16:44:27, Nate Chapin wrote:
> Oops...good catch. LGTM. Is there a bug/test associated with this?

Thanks. :) I'm not sure about tests regarding this in Chromium, we discovered
this in our testing framework.

[robertn, 2016-06-14 08:25:15]

The CQ bit was checked by robertn@opera.com

[commit-bot: I haz the power, 2016-06-14 08:25:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2060193002/1

[commit-bot: I haz the power, 2016-06-14 08:28:58]

Description was changed from

==========
Clear the SharedBuffer when clearing the image

Previously, in the case of the image failing to be decoded, the buffer
was cleared because error() was called. This was changed in the
following patch:


https://chromium.googlesource.com/chromium/src/+/61e34ff7dd4ac48b8c4275eb3f54...

The patch changes it so that only clear() is called, which does not
clear the m_data buffer. This patch changes clear() to also clear the
buffer.

BUG=
==========

to

==========
Clear the SharedBuffer when clearing the image

Previously, in the case of the image failing to be decoded, the buffer
was cleared because error() was called. This was changed in the
following patch:


https://chromium.googlesource.com/chromium/src/+/61e34ff7dd4ac48b8c4275eb3f54...

The patch changes it so that only clear() is called, which does not
clear the m_data buffer. This patch changes clear() to also clear the
buffer.

BUG=
==========

[commit-bot: I haz the power, 2016-06-14 08:28:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-14 08:29:06]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-14 08:30:55]

Description was changed from

==========
Clear the SharedBuffer when clearing the image

Previously, in the case of the image failing to be decoded, the buffer
was cleared because error() was called. This was changed in the
following patch:


https://chromium.googlesource.com/chromium/src/+/61e34ff7dd4ac48b8c4275eb3f54...

The patch changes it so that only clear() is called, which does not
clear the m_data buffer. This patch changes clear() to also clear the
buffer.

BUG=
==========

to

==========
Clear the SharedBuffer when clearing the image

Previously, in the case of the image failing to be decoded, the buffer
was cleared because error() was called. This was changed in the
following patch:


https://chromium.googlesource.com/chromium/src/+/61e34ff7dd4ac48b8c4275eb3f54...

The patch changes it so that only clear() is called, which does not
clear the m_data buffer. This patch changes clear() to also clear the
buffer.

BUG=

Committed: https://crrev.com/d6ae2381c93fcc66c72452327c0b55e79eca228f
Cr-Commit-Position: refs/heads/master@{#399668}
==========

[commit-bot: I haz the power, 2016-06-14 08:30:57]

Patchset 1 (id:??) landed as
https://crrev.com/d6ae2381c93fcc66c72452327c0b55e79eca228f
Cr-Commit-Position: refs/heads/master@{#399668}