Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: tests/compiler/dart2js/serialization/test_helper.dart

Issue 2060183002: Serialize metadata (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comment. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/serialization/model_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/serialization/test_helper.dart
diff --git a/tests/compiler/dart2js/serialization/test_helper.dart b/tests/compiler/dart2js/serialization/test_helper.dart
index 34f40aa76b4c634dfd107d1ff2f0d91868c6bfd5..a6dddf9069ac5b48367379cf54cf08f932aca978 100644
--- a/tests/compiler/dart2js/serialization/test_helper.dart
+++ b/tests/compiler/dart2js/serialization/test_helper.dart
@@ -436,6 +436,7 @@ void checkSets(
String messagePrefix,
bool sameElement(a, b),
{bool failOnUnfound: true,
+ bool failOnExtra: true,
bool verbose: false,
void onSameElement(a, b)}) {
List<List> common = <List>[];
@@ -458,7 +459,8 @@ void checkSets(
String message = sb.toString();
if (unfound.isNotEmpty || remaining.isNotEmpty) {
- if (failOnUnfound || remaining.isNotEmpty) {
+ if ((failOnUnfound && unfound.isNotEmpty) ||
+ (failOnExtra && remaining.isNotEmpty)) {
Expect.fail(message);
} else {
print(message);
« no previous file with comments | « tests/compiler/dart2js/serialization/model_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698