pkg/compiler/lib/src/constants/values.dart - Issue 2060183002: Serialize metadata

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/constants/values.dart

Issue 2060183002: Serialize metadata (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comment. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/constants/values.dart

diff --git a/pkg/compiler/lib/src/constants/values.dart b/pkg/compiler/lib/src/constants/values.dart

index 37f5646d7e3600f22f575df233d3153b2273f62e..670d1efde88f7e6040d7177b6bb1a62520f8851c 100644

--- a/pkg/compiler/lib/src/constants/values.dart

+++ b/pkg/compiler/lib/src/constants/values.dart

@@ -28,6 +28,7 @@ abstract class ConstantValueVisitor<R, A> {

R visitInterceptor(InterceptorConstantValue constant, A arg);

R visitSynthetic(SyntheticConstantValue constant, A arg);

R visitDeferred(DeferredConstantValue constant, A arg);

+ R visitNonConstant(NonConstantValue constant, A arg);

}

abstract class ConstantValue {

@@ -762,7 +763,7 @@ class NonConstantValue extends ConstantValue {

@override

accept(ConstantValueVisitor visitor, arg) {

- // TODO(johnniwinther): Should this be part of the visiting?

+ return visitor.visitNonConstant(this, arg);

}

@override