Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2060183002: Serialize metadata (Closed)

Created:
4 years, 6 months ago by Johnni Winther
Modified:
4 years, 6 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Cleanup and fixes #

Total comments: 4

Patch Set 3 : Updated cf. comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -76 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 1 chunk +15 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 1 3 chunks +24 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/constants/values.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_emitter.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart View 1 4 chunks +1 line, -37 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_interop_analysis.dart View 1 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 1 2 chunks +8 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/constant_ordering.dart View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 1 4 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/serialization/element_serialization.dart View 15 chunks +33 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/keys.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 6 chunks +50 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/types/constants.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/serialization/equivalence_test.dart View 1 6 chunks +22 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/serialization/model_test.dart View 2 chunks +1 line, -6 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_helper.dart View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Johnni Winther
4 years, 6 months ago (2016-06-13 14:25:30 UTC) #2
Harry Terkelsen
lgtm https://codereview.chromium.org/2060183002/diff/20001/pkg/compiler/lib/src/compile_time_constants.dart File pkg/compiler/lib/src/compile_time_constants.dart (right): https://codereview.chromium.org/2060183002/diff/20001/pkg/compiler/lib/src/compile_time_constants.dart#newcode339 pkg/compiler/lib/src/compile_time_constants.dart:339: // expression as erroneous but the JavaScript constant ...
4 years, 6 months ago (2016-06-13 17:26:12 UTC) #3
Johnni Winther
https://codereview.chromium.org/2060183002/diff/20001/pkg/compiler/lib/src/compile_time_constants.dart File pkg/compiler/lib/src/compile_time_constants.dart (right): https://codereview.chromium.org/2060183002/diff/20001/pkg/compiler/lib/src/compile_time_constants.dart#newcode339 pkg/compiler/lib/src/compile_time_constants.dart:339: // expression as erroneous but the JavaScript constant system ...
4 years, 6 months ago (2016-06-16 07:39:45 UTC) #4
Johnni Winther
Committed patchset #3 (id:40001) manually as f8e3f223476b461d4c9fcf89b691441f73532bf4 (presubmit successful).
4 years, 6 months ago (2016-06-16 07:45:20 UTC) #6
Johnni Winther
4 years, 6 months ago (2016-06-16 10:13:25 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
5f3cf6f9327860cae33a0161e41ff518ebd24a96 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698