Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Side by Side Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 2060173002: [fullcodegen] Factor out VisitRegExpLiteral from architectures. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 1351 matching lines...) Expand 10 before | Expand all | Expand 10 after
1362 ? Runtime::kLoadLookupSlot 1362 ? Runtime::kLoadLookupSlot
1363 : Runtime::kLoadLookupSlotInsideTypeof; 1363 : Runtime::kLoadLookupSlotInsideTypeof;
1364 __ CallRuntime(function_id); 1364 __ CallRuntime(function_id);
1365 __ bind(&done); 1365 __ bind(&done);
1366 context()->Plug(v0); 1366 context()->Plug(v0);
1367 } 1367 }
1368 } 1368 }
1369 } 1369 }
1370 1370
1371 1371
1372 void FullCodeGenerator::VisitRegExpLiteral(RegExpLiteral* expr) {
1373 Comment cmnt(masm_, "[ RegExpLiteral");
1374 __ lw(a3, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
1375 __ li(a2, Operand(Smi::FromInt(expr->literal_index())));
1376 __ li(a1, Operand(expr->pattern()));
1377 __ li(a0, Operand(Smi::FromInt(expr->flags())));
1378 FastCloneRegExpStub stub(isolate());
1379 __ CallStub(&stub);
1380 context()->Plug(v0);
1381 }
1382
1383
1384 void FullCodeGenerator::EmitAccessor(ObjectLiteralProperty* property) { 1372 void FullCodeGenerator::EmitAccessor(ObjectLiteralProperty* property) {
1385 Expression* expression = (property == NULL) ? NULL : property->value(); 1373 Expression* expression = (property == NULL) ? NULL : property->value();
1386 if (expression == NULL) { 1374 if (expression == NULL) {
1387 __ LoadRoot(a1, Heap::kNullValueRootIndex); 1375 __ LoadRoot(a1, Heap::kNullValueRootIndex);
1388 PushOperand(a1); 1376 PushOperand(a1);
1389 } else { 1377 } else {
1390 VisitForStackValue(expression); 1378 VisitForStackValue(expression);
1391 if (NeedsHomeObject(expression)) { 1379 if (NeedsHomeObject(expression)) {
1392 DCHECK(property->kind() == ObjectLiteral::Property::GETTER || 1380 DCHECK(property->kind() == ObjectLiteral::Property::GETTER ||
1393 property->kind() == ObjectLiteral::Property::SETTER); 1381 property->kind() == ObjectLiteral::Property::SETTER);
(...skipping 2426 matching lines...) Expand 10 before | Expand all | Expand 10 after
3820 reinterpret_cast<uint32_t>( 3808 reinterpret_cast<uint32_t>(
3821 isolate->builtins()->OnStackReplacement()->entry())); 3809 isolate->builtins()->OnStackReplacement()->entry()));
3822 return ON_STACK_REPLACEMENT; 3810 return ON_STACK_REPLACEMENT;
3823 } 3811 }
3824 3812
3825 3813
3826 } // namespace internal 3814 } // namespace internal
3827 } // namespace v8 3815 } // namespace v8
3828 3816
3829 #endif // V8_TARGET_ARCH_MIPS 3817 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/full-codegen/ia32/full-codegen-ia32.cc ('k') | src/full-codegen/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698