Issue 2060143002: Cache fromEnvironment state in ConstructorElementCommon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2060143002: Cache fromEnvironment state in ConstructorElementCommon (Closed)

Created:
4 years, 6 months ago by Johnni Winther

Modified:
4 years, 6 months ago

Reviewers:
Harry Terkelsen

CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Cache fromEnvironment state in ConstructorElementCommon Cache the value of the properties `isFromEnvironmentConstructor`, `isIntFromEnvironmentConstructor`, `isBoolFromEnvironmentConstructor`, and `isStringFromEnvironmentConstructor` in ConstructorElementCommon. R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/77c689fd16431caca9ec19a43be9e5830eb3928d

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -16 lines)			Patch
	M	pkg/compiler/lib/src/elements/common.dart	View		1 chunk	+28 lines, -14 lines	0 comments	Download
	M	pkg/compiler/lib/src/typechecker.dart	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Johnni Winther

4 years, 6 months ago (2016-06-15 07:43:50 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
77c689fd16431caca9ec19a43be9e5830eb3928d (presubmit successful).