Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2477)

Issue 206013003: Cache all the results in SVGSMILElement::repeatCount() (Closed)

Created:
6 years, 9 months ago by fs
Modified:
6 years, 9 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

Cache all the results in SVGSMILElement::repeatCount() The null-attribute and 'indefinite' cases were not cached, which made this method do some unnecessary work for each animation update. BUG=354520 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169755

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M Source/core/svg/animation/SVGSMILElement.cpp View 1 chunk +14 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
fs
6 years, 9 months ago (2014-03-21 17:17:42 UTC) #1
pdr.
On 2014/03/21 17:17:42, fs wrote: LGTM
6 years, 9 months ago (2014-03-21 17:40:32 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-21 17:40:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/206013003/1
6 years, 9 months ago (2014-03-21 17:40:41 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 18:06:56 UTC) #5
Message was sent while issue was closed.
Change committed as 169755

Powered by Google App Engine
This is Rietveld 408576698