Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2060103002: Use the correct height on cells when calculating row height in paged contexts (Closed)

Created:
4 years, 6 months ago by rhogan
Modified:
4 years, 6 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the correct height on cells when calculating row height in paged contexts BUG=617443 Committed: https://crrev.com/8ccbfafd2fa86d6a486ee731ca0c466797319f15 Cr-Commit-Position: refs/heads/master@{#400937}

Patch Set 1 #

Patch Set 2 : Updated #

Patch Set 3 : bug 617443 #

Patch Set 4 : bug 617443 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fragmentation/cells-with-intrinsic-padding.html View 1 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fragmentation/cells-with-intrinsic-padding-expected.html View 1 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/printing/thead-repeats-at-top-of-each-page-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableRow.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
rhogan
Hi eae: don't want to spam you with my CLs but I'm not sure who ...
4 years, 6 months ago (2016-06-16 22:31:03 UTC) #2
eae
LGTM Please keep sending them my way for now. I really like the added comment, ...
4 years, 6 months ago (2016-06-21 09:08:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060103002/60001
4 years, 6 months ago (2016-06-21 09:08:46 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-21 09:52:22 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 09:53:41 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8ccbfafd2fa86d6a486ee731ca0c466797319f15
Cr-Commit-Position: refs/heads/master@{#400937}

Powered by Google App Engine
This is Rietveld 408576698