third_party/WebKit/LayoutTests/fast/html/pushstate-ignore-query-file.html - Issue 2060093002: Allow 'history.pushState' to modify query string for unique and file origins.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/html/pushstate-ignore-query-file.html

Issue 2060093002: Allow 'history.pushState' to modify query string for unique and file origins. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Allow 'history.pushState' to modify query string for unique and file origins. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/html/pushstate-ignore-query-file-expected.txt » ('j') | third_party/WebKit/Source/core/frame/History.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <body>
	Mike West 2016/06/14 08:44:59 Please also adjust `LayoutTests/http/tests/navigat Please also adjust `LayoutTests/http/tests/navigation/pushstate-at-unique-origin-denied.php` to check `?` behavior, as well as a combination of query and fragment.
	2 <script>

	3

	4 if (window.testRunner)

	5 testRunner.dumpAsText();

	6 if(window.location.protocol=="file:") {
	Mike West 2016/06/14 08:44:59 Nit: Space between `if` and `(`. Nit: Space between `if` and `(`.
	7 try {

	8 history.pushState({}, 'dummyTitle', '#foo=bar');
	Mike West 2016/06/14 08:44:59 Nit: Indentation. Nit: Indentation.
	9 history.pushState({}, 'dummyTitle', '?foo=bar');
	Mike West 2016/06/14 08:44:59 Please also add `?foo#bar`. Please also add `?foo#bar`.
	10 document.write("PASS."+document.URL);

	11 } catch(e) {

	12 document.write("FAILED.The reason:"+e.message);

	13 }

	14 } else {

	15 document.write("FAILED.");

	16 }
	Mike West 2016/06/14 08:44:59 New tests should be written in terms of `testharne New tests should be written in terms of `testharness.js` assertions (because they can then be pretty easily upstreamed to Web Platform Tests, and used in other browsers). `LayoutTests/http/tests/navigation/pushstate-at-unique-origin-denied.php` gives you a pretty good example of what that kind of test structure might look like.
	17 </script>

OLD	NEW