Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 2060083002: LocalFrame::localLayerTreeAsText() ==> layerTreeAsText() (Closed)

Created:
4 years, 6 months ago by Xianzhu
Modified:
4 years, 6 months ago
Reviewers:
pdr.
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

LocalFrame::localLayerTreeAsText() ==> layerTreeAsText() There is no "local" layer tree as the layer tree is crossing frame boundaries. Rename localLayerTreeAsText() to layerTreeAsText() and remove the original layerTreeAsText(). The test expectations that included sub-frame layer trees just repeated subtrees in the main layers layer tree. Committed: https://crrev.com/636641340227b208ddcfe970e72a1fe17628d79c Cr-Commit-Position: refs/heads/master@{#399400}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1125 lines) Patch
M third_party/WebKit/LayoutTests/compositing/force-compositing-mode/overflow-iframe-enter-compositing-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/force-compositing-mode/overflow-iframe-layer-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/iframes/become-composited-nested-iframes-expected.txt View 1 chunk +0 lines, -162 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/iframes/become-overlapped-iframe-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/iframes/composited-parent-iframe-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/iframes/connect-compositing-iframe-delayed-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/iframes/connect-compositing-iframe-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/iframes/connect-compositing-iframe2-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/iframes/connect-compositing-iframe3-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/iframes/enter-compositing-iframe-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/iframes/iframe-resize-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/iframes/iframe-size-from-zero-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/iframes/invisible-nested-iframe-show-expected.txt View 1 chunk +0 lines, -81 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/iframes/overlapped-iframe-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/iframes/overlapped-iframe-iframe-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/iframes/overlapped-nested-iframes-expected.txt View 1 chunk +0 lines, -162 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/iframes/resizer-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/iframes/scrolling-iframe-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overlap-test-with-filter-expected.txt View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/rtl/rtl-iframe-absolute-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/rtl/rtl-iframe-fixed-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/rtl/rtl-iframe-relative-expected.txt View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/compositing/iframes/invisible-nested-iframe-hide-expected.txt View 1 chunk +0 lines, -81 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/compositing/iframes/invisible-nested-iframe-show-expected.txt View 1 chunk +0 lines, -81 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 2 chunks +1 line, -22 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Xianzhu
4 years, 6 months ago (2016-06-12 02:35:26 UTC) #2
pdr.
LGTM
4 years, 6 months ago (2016-06-12 04:07:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060083002/1
4 years, 6 months ago (2016-06-12 18:32:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/176426)
4 years, 6 months ago (2016-06-12 19:52:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060083002/1
4 years, 6 months ago (2016-06-12 20:09:08 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/245386)
4 years, 6 months ago (2016-06-12 22:09:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060083002/1
4 years, 6 months ago (2016-06-12 23:19:27 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 00:34:57 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 00:34:59 UTC) #17
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 00:36:59 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/636641340227b208ddcfe970e72a1fe17628d79c
Cr-Commit-Position: refs/heads/master@{#399400}

Powered by Google App Engine
This is Rietveld 408576698