WebUI: cr-search-field: Remove delegation pattern, use simple event instead.

chrome/browser/resources/md_extensions/manager.js

Index: chrome/browser/resources/md_extensions/manager.js
diff --git a/chrome/browser/resources/md_extensions/manager.js b/chrome/browser/resources/md_extensions/manager.js
index c90d7f88114ae693ce85195bfebd7717d4d200a5..0849c6ca507e341aa45518963f1acdaf43b0f74b 100644
--- a/chrome/browser/resources/md_extensions/manager.js
+++ b/chrome/browser/resources/md_extensions/manager.js
@@ -91,11 +91,18 @@ cr.define('extensions', function() {
           /** @type {extensions.Sidebar} */(this.$$('extensions-sidebar'));
       this.listHelper_ = new ListHelper(this);
       this.sidebar.setListDelegate(this.listHelper_);
-      this.$.toolbar.setSearchDelegate(new SearchHelper(this));
       this.readyPromiseResolver.resolve();
     },
 
     /**
+     * @param {!Event} event

[Devlin, 2016/06/14 19:19:32]

!CustomEvent

[dpapad, 2016/06/14 19:29:48]

Already done at patch 6.

+     * @private
+     */
+    onFilterChanged_: function(event) {
+      this.filter = event.detail;

[Devlin, 2016/06/14 19:19:32]

Also wrong before this, but I think this should be this.set('filter',
event.detail)

[dpapad, 2016/06/14 19:29:48]

My understanding is that direct assignment and usage of this.set() helper are
entirely equivalent in this case. The only time where these two are not
equivalent is when modifying a deep object, as follows

this.myObj.foo.bar = 'baz'; // does not trigger observers.
this.set('myObj.foo.bar', 'baz'); // triggers observers.

[Devlin, 2016/06/14 20:07:44]

Ah, I didn't realize that it was only for deep properties.  Good to know.

+    },
+
+    /**
      * @param {chrome.developerPrivate.ExtensionType} type The type of item.
      * @return {string} The ID of the list that the item belongs in.
      * @private
@@ -277,21 +284,5 @@ cr.define('extensions', function() {
     },
   };
 
-  /**
-   * @param {extensions.Manager} manager
-   * @constructor
-   * @implements {SearchFieldDelegate}
-   */
-  function SearchHelper(manager) {
-    this.manager_ = manager;
-  }
-
-  SearchHelper.prototype = {
-    /** @override */
-    onSearchTermSearch: function(searchTerm) {
-      this.manager_.filter = searchTerm;
-    },
-  };
-
   return {Manager: Manager};
 });