WebUI: cr-search-field: Remove delegation pattern, use simple event instead.

chrome/browser/resources/md_extensions/manager.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * The different pages that can be shown at a time.
  * Note: This must remain in sync with the order in manager.html!
  * @enum {string}
  */
 var Page = {
@@ skipping 73 matching lines @@
     created: function() {
       this.readyPromiseResolver = new PromiseResolver();
     },
 
     ready: function() {
       /** @type {extensions.Sidebar} */
       this.sidebar =
           /** @type {extensions.Sidebar} */(this.$$('extensions-sidebar'));
       this.listHelper_ = new ListHelper(this);
       this.sidebar.setListDelegate(this.listHelper_);
-      this.$.toolbar.setSearchDelegate(new SearchHelper(this));
       this.readyPromiseResolver.resolve();
     },
 
     /**
+     * @param {!Event} event

[Devlin, 2016/06/14 19:19:32]

!CustomEvent

[dpapad, 2016/06/14 19:29:48]

Already done at patch 6.

+     * @private
+     */
+    onFilterChanged_: function(event) {
+      this.filter = event.detail;

[Devlin, 2016/06/14 19:19:32]

Also wrong before this, but I think this should be this.set('filter',
event.detail)

[dpapad, 2016/06/14 19:29:48]

My understanding is that direct assignment and usage of this.set() helper are
entirely equivalent in this case. The only time where these two are not
equivalent is when modifying a deep object, as follows

this.myObj.foo.bar = 'baz'; // does not trigger observers.
this.set('myObj.foo.bar', 'baz'); // triggers observers.

[Devlin, 2016/06/14 20:07:44]

Ah, I didn't realize that it was only for deep properties.  Good to know.

+    },
+
+    /**
      * @param {chrome.developerPrivate.ExtensionType} type The type of item.
      * @return {string} The ID of the list that the item belongs in.
      * @private
      */
     getListId_: function(type) {
       var listId;
       var ExtensionType = chrome.developerPrivate.ExtensionType;
       switch (type) {
         case ExtensionType.HOSTED_APP:
         case ExtensionType.LEGACY_PACKAGED_APP:
@@ skipping 161 matching lines @@
 
       this.manager_.$['items-list'].set('items', assert(items));
       this.manager_.changePage(Page.ITEM_LIST);
     },
 
     showKeyboardShortcuts: function() {
       this.manager_.changePage(Page.KEYBOARD_SHORTCUTS);
     },
   };
 
-  /**
-   * @param {extensions.Manager} manager
-   * @constructor
-   * @implements {SearchFieldDelegate}
-   */
-  function SearchHelper(manager) {
-    this.manager_ = manager;
-  }
-
-  SearchHelper.prototype = {
-    /** @override */
-    onSearchTermSearch: function(searchTerm) {
-      this.manager_.filter = searchTerm;
-    },
-  };
-
   return {Manager: Manager};
 });