Fix source spans hashcode implementation

pkg/source_maps/lib/span.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Dart classes representing the souce spans and source files.
 library source_maps.span;
 
 import 'dart:utf' show stringToCodepoints;
 import 'dart:math' show min, max;
 
@@ skipping 51 matching lines @@
   String get formatLocation => start.formatString;
 
   String getLocationMessage(String message,
       {bool useColors: false, String color}) {
     return '$formatLocation: $message';
   }
 
   bool operator ==(Span other) =>
     sourceUrl == other.sourceUrl && start == other.start && end == other.end;
 
-  int get hashCode => sourceUrl.hashCode + start + (31 * (end - start));
+  int get hashCode => sourceUrl.hashCode + start.offset + (31 * length);

[justinfagnani, 2013/07/26 00:44:22]

length includes information from start.offset already, why not just end.offset?

[Siggi Cherem (dart-lang), 2013/07/26 00:50:12]

I could argue the opposite: end.offset is always > start, so only length is a
relevant piece =)

I think it's ok either way, but I'm afraid of offsets*31 being too large, so
just encoding the length might be better. 

 
   String toString() => '<$runtimeType: $start $end $formatLocation $text>';
 }
 
 /// A location in the source text
 abstract class Location implements Comparable {
   /// Url of the source containing this span.
   String get sourceUrl;
 
   /// The offset of this location, 0-based.
   final int offset;
 
   /// The 0-based line in the source of this location.
   int get line;
 
   /// The 0-based column in the source of this location.
   int get column;
 
   Location(this.offset);
 
   /// Compares two locations. If the locations are not in the same source, this
   /// method generates an error.
   int compareTo(Location other) {
     if (sourceUrl != other.sourceUrl) {
       throw new ArgumentError('can only compare locations of the same source');
     }
     return offset - other.offset;
   }
 
+  bool operator ==(Location other) =>
+      sourceUrl == other.sourceUrl && offset == other.offset;
+
+  int get hashCode => sourceUrl.hashCode + offset;
+
   String toString() => '(Location $offset)';
   String get formatString => '$sourceUrl:${line + 1}:${column + 1}';
 }
 
 /// Implementation of [Location] with fixed values given at allocation time.
 class FixedLocation extends Location {
   final String sourceUrl;
   final int line;
   final int column;
 
@@ skipping 235 matching lines @@
   int getOffset(int line, int column) =>
     super.getOffset(line - _baseLine,
         line == _baseLine ? column - _baseColumn : column) + _baseOffset;
 
   /// Retrieve the text associated with the specified range. This method
   /// operates on the real offsets from the original file, so that error
   /// messages can be reported accurately.
   String getText(int start, [int end]) =>
     super.getText(start - _baseOffset, end == null ? null : end - _baseOffset);
 }