[Android] Move to new device status and recovery scripts.

scripts/slave/recipe_modules/chromium_android/example.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from recipe_engine.types import freeze
 
 DEPS = [
     'adb',
     'chromium',
     'chromium_android',
@@ skipping 130 matching lines @@
         api.chromium.output_dir.join('chrome_public_apk', 'classes.dex.zip'))
 
   if config.get('specific_install'):
     api.chromium_android.adb_install_apk('Chrome.apk', devices=['abc123'])
 
   api.adb.root_devices()
   api.chromium_android.spawn_logcat_monitor()
 
   failure = False
   try:
-    # TODO(luqui): remove redundant cruft, need one consistent API.
+    # detect_and_setup_devices contains device recovery, provisiong, and status.
     api.chromium_android.detect_and_setup_devices()
-
-    api.chromium_android.device_status_check(
-      restart_usb=config.get('restart_usb', False))
-
+    api.chromium_android.device_status_check()
+    # Needed to test all flags to provision devices.
     api.chromium_android.provision_devices(
         skip_wipe=config.get('skip_wipe', False),
         disable_location=config.get('disable_location', False),
         min_battery_level=config.get('min_battery_level'),
         max_battery_temp=config.get('max_battery_temp'),
         reboot_timeout=1800,
         remove_system_webview=config.get('remove_system_webview', False),
         disable_system_chrome=config.get('disable_system_chrome', False))
 
+

[jbudorick, 2016/06/15 14:05:38]

?

[rnephew (Reviews Here), 2016/06/15 16:05:13]

Done.

   except api.step.StepFailure as f:
     failure = f
 
   if config.get('downgrade'):
     api.chromium_android.adb_install_apk('apk', allow_downgrade=True)
 
   api.chromium_android.monkey_test()
 
   try:
     if config.get('perf_config'):
@@ skipping 56 matching lines @@
         buildername=buildername,
         slavename='tehslave',
         repo_name='src/repo',
         patch_url='https://the.patch.url/the.patch',
         repo_url='svn://svn.chromium.org/chrome/trunk/src',
         revision='4f4b02f6b7fa20a3a25682c457bbc8ad589c8a00',
         internal=True)
 
   for buildername in BUILDERS:
     yield api.test('%s_basic' % buildername) + properties_for(buildername)
 

[jbudorick, 2016/06/15 14:05:38]

I would expect some of these to fail in recovery.

[rnephew (Reviews Here), 2016/06/15 16:05:13]

Done.

   yield (api.test('tester_no_devices') +
          properties_for('tester') +
-         api.step_data('device_status_check', retcode=1))
+         api.step_data('device_status', retcode=1))
 
   yield (api.test('tester_other_device_failure') +
          properties_for('tester') +
-         api.step_data('device_status_check', retcode=2))
+         api.step_data('device_status', retcode=2))
 
   yield (api.test('tester_with_step_warning') +
          properties_for('tester') +
          api.step_data('unittests', retcode=88))
 
   yield (api.test('tester_blacklisted_devices') +
          properties_for('tester') +
          api.override_step_data('provision_devices',
                                 api.json.output(['abc123', 'def456'])))
 
   yield (api.test('tester_offline_devices') +
          properties_for('tester') +
-         api.override_step_data('device_status_check',
+         api.override_step_data('device_status',
                                 api.json.output([{}, {}])))
 
   yield (api.test('perf_tests_failure') +
       properties_for('perf_runner') +
       api.step_data('perf_test.foo', retcode=1))
 
   yield (api.test('gerrit_refs') +
       api.properties.generic(
         buildername='gerrit_try_builder',
         slavename='testslave',
@@ skipping 92 matching lines @@
              'Created xml report file at file:///path/to/testResult.xml',
              stream='stdout')) +
          api.override_step_data('Read test result and report failures',
              api.raw_io.output(result_xml_with_unexpected_failure_method)))
 
   yield (api.test('webview_cts_invalid_output') +
          properties_for('webview_cts') +
          api.override_step_data('Run CTS', api.raw_io.stream_output(
              'Invalid CTS output here...',
              stream='stdout')))