[Android] Move to new device status and recovery scripts.

scripts/slave/recipe_modules/chromium_android/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import contextlib
 import datetime
 import json
 import os
 import re
 import urllib
@@ skipping 14 matching lines @@
 
   def get_config_defaults(self):
     return {
       'REVISION': self.m.properties.get('revision', ''),
       'CHECKOUT_PATH': self.m.path['checkout'],
     }
 
   @property
   def devices(self):
     assert self._devices is not None,\
-        'devices is only available after device_status_check()'
+        'devices is only available after device_status()'
     return self._devices
 
   @property
   def out_path(self):
     return self.m.path['checkout'].join('out')
 
   @property
   def coverage_dir(self):
     return self.out_path.join(self.c.BUILD_CONFIG, 'coverage')
 
@@ skipping 271 matching lines @@
     args = ['--verbose', '--adb-path', self.m.adb.adb_path()]
     return self.m.python('authorize_adb_devices', script, args, infra_step=True,
                          env=self.m.chromium.get_env())
 
   def detect_and_setup_devices(self, restart_usb=False, skip_wipe=False,
                                disable_location=False, min_battery_level=None,
                                disable_network=False, disable_java_debug=False,
                                reboot_timeout=None, max_battery_temp=None,
                                remove_system_webview=False):
     self.authorize_adb_devices()
-    self.device_status_check(restart_usb=restart_usb)
+    self.device_recovery()
     self.provision_devices(
       skip_wipe=skip_wipe, disable_location=disable_location,
       min_battery_level=min_battery_level, disable_network=disable_network,
       disable_java_debug=disable_java_debug, reboot_timeout=reboot_timeout,
       max_battery_temp=max_battery_temp,
       remove_system_webview=remove_system_webview)
+    self.device_status()
 
   @property
   def blacklist_file(self):
     return self.out_path.join('bad_devices.json')
 
-  def device_status_check(self, restart_usb=False, **kwargs):
-    # TODO(phajdan.jr): Remove path['build'] usage, http://crbug.com/437264 .

[jbudorick, 2016/06/15 14:05:38]

I think this TODO should be maintained for now.

-    devices_path = self.m.path['build'].join('site_config', '.known_devices')
+  # TODO(rnephew): Get rid of this when everything calls device_recovery and
+  # device_status directly.
+  def device_status_check(self):

[jbudorick, 2016/06/15 14:05:38]

What's still calling this? Downstream?

[rnephew (Reviews Here), 2016/06/15 14:32:45]

Im more putting it in there as a just in case I missed something. I wish there
was a way to log better in recipes so I could put a deprecation warning to make
things easier to hunt down. Any suggestions on a way to do that?

[jbudorick, 2016/06/15 14:48:50]

I don't know of a good way to do this short of adding something to the results
presentation, and that seems drastic.

+    self.device_recovery()
+    self.device_status()
+
+  def device_recovery(self, restart_usb=False, **kwargs):
+    known_devices_path = self.m.path['build'].join('site_config',

[jbudorick, 2016/06/15 14:05:38]

This should probably be in its own private function or property.

[rnephew (Reviews Here), 2016/06/15 16:05:13]

Done.

+                                                   '.known_devices')
     args = [
-        '--adb-path', self.m.adb.adb_path(),
         '--blacklist-file', self.blacklist_file,
+        '--known-devices-file', known_devices_path,
+        '-v'
+    ]
+    self.m.step(
+        'device_recovery',
+        [self.m.path['checkout'].join('third_party', 'catapult', 'devil',
+                                      'devil', 'android', 'tools',
+                                      'device_recovery.py')] + args,
+          env=self.m.chromium.get_env(),
+          infra_step=True,
+          **kwargs)
+
+  def device_status(self, **kwargs):
+    known_devices_path = self.m.path['build'].join('site_config',
+                                                   '.known_devices')
+    buildbot_file = '/home/chrome-bot/.adb_device_info'
+    args = [
         '--json-output', self.m.json.output(),
-        '--known-devices-file', devices_path,
+        '--blacklist-file', self.blacklist_file,
+        '--known-devices-file', known_devices_path,
+        '--buildbot-path', buildbot_file,
+        '-v', '--overwrite-known-devices-files',
     ]
-    if restart_usb:
-      args += ['--restart-usb']
-
     try:
       result = self.m.step(
-          'device_status_check',
-          [self.m.path['checkout'].join('build', 'android', 'buildbot',
-                                'bb_device_status_check.py')] + args,
+          'device_status',
+          [self.m.path['checkout'].join('third_party', 'catapult', 'devil',
+                                        'devil', 'android', 'tools',
+                                        'device_status.py')] + args,
           step_test_data=lambda: self.m.json.test_api.output([
               {
                 "battery": {
                     "status": "5",
                     "scale": "100",
                     "temperature": "249",
                     "level": "100",
                     "AC powered": "false",
                     "health": "2",
                     "voltage": "4286",
@@ skipping 37 matching lines @@
           **kwargs)
       self._devices = []
       offline_device_index = 1
       for d in result.json.output:
         try:
           if not d['usb_status']:
             key = '%s: missing' % d['serial']
           elif d['adb_status'] != 'device':
             key = '%s: adb status %s' % (d['serial'], d['adb_status'])
           elif d['blacklisted']:
             key = '%s: blacklisted' % d['serial']

[rnephew (Reviews Here), 2016/06/15 16:05:13]

Isn't it already done here (displaying blacklisted devices) for device status?

           else:
             key = '%s %s %s' % (d['type'], d['build'], d['serial'])
             self._devices.append(d['serial'])
         except KeyError:
           key = 'unknown device %d' % offline_device_index
           offline_device_index += 1
         result.presentation.logs[key] = self.m.json.dumps(
             d, indent=2).splitlines()
       result.presentation.step_text = 'Online devices: %s' % len(self._devices)
       return result
@@ skipping 55 matching lines @@
     if emulators:
       args.append('--emulators')
     result = self.m.python(
       'provision_devices',
       self.m.path['checkout'].join(
           'build', 'android', 'provision_devices.py'),
       args=args,
       env=self.m.chromium.get_env(),
       infra_step=True,
       **kwargs)
     blacklisted_devices = result.json.output

[jbudorick, 2016/06/15 14:05:38]

I think the blacklist display stuff should move up to device_status.

[rnephew (Reviews Here), 2016/06/15 16:05:13]

See above comment on line 437.

     if blacklisted_devices:
       result.presentation.status = self.m.step.WARNING
       for d in blacklisted_devices:
         key = 'blacklisted %s' % d
         result.presentation.logs[key] = [d]
 
   def apk_path(self, apk):
     return self.m.chromium.output_dir.join('apks', apk) if apk else None
 
   def adb_install_apk(self, apk, allow_downgrade=False, devices=None):
@@ skipping 368 matching lines @@
     self.create_adb_symlink()
     if self.c.gce_setup:
       self.launch_gce_instances(snapshot=self.c.gce_snapshot,
                                 count=self.c.gce_count)
       self.spawn_logcat_monitor()
       self.provision_devices(emulators=True,
                              remove_system_webview=remove_system_webview)
     else:
       self.spawn_logcat_monitor()
       self.authorize_adb_devices()
-      self.device_status_check()
+      self.device_recovery()
       if perf_setup:
         kwargs = {
             'min_battery_level': 95,
             'disable_network': True,
             'disable_java_debug': True,
             'max_battery_temp': 350}
       else:
         kwargs = {}
       self.provision_devices(remove_system_webview=remove_system_webview,
                              **kwargs)
+      self.device_status()
       if self.m.chromium.c.gyp_env.GYP_DEFINES.get('asan', 0) == 1:
         self.asan_device_setup()
 
       self.spawn_device_monitor()
 
   def common_tests_final_steps(self, logcat_gs_bucket='chromium-android'):
     if not self.c.gce_setup:
       self.shutdown_device_monitor()
     self.logcat_dump(gs_bucket=logcat_gs_bucket)
     self.stack_tool_steps()
@@ skipping 402 matching lines @@
       script = self.c.test_runner
       if wrapper_script_suite_name:
         script = self.m.chromium.output_dir.join('bin', 'run_%s' %
                                                  wrapper_script_suite_name)
       else:
         env = kwargs.get('env', {})
         env['CHROMIUM_OUTPUT_DIR'] = env.get('CHROMIUM_OUTPUT_DIR',
                                              self.m.chromium.output_dir)
         kwargs['env'] = env
       return self.m.python(step_name, script, args, **kwargs)