Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2059983002: Remove unnecessary dependencies on mojo/edk/system (Closed)

Created:
4 years, 6 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 6 months ago
Reviewers:
jam
CC:
Aaron Boodman, abarth-chromium, alokp+watch_chromium.org, ben+mojo_chromium.org, blink-reviews, blink-reviews-api_chromium.org, cc-bugs_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, dglazkov+blink, elijahtaylor+arcwatch_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, hidehiko+watch_chromium.org, jam, kalyank, lhchavez+watch_chromium.org, qsr+mojo_chromium.org, rjkroege, sadrul, tdresser+watch_chromium.org, timvolodine, viettrungluu+watch_chromium.org, yusukes+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cleanup
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary dependencies on mojo/edk/system Since we no longer need to compensate for intentionally underspecified dependencies on public Mojo APIs, targets which don't directly depend on mojo/edk sources no longer need to express a direct dependency on //mojo/edk/system. This removes all the unnecessary ones, and as a result also gets rid of the blink_for_unittests target which only needed to exist because of this weirdness. BUG=612500 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/c547787ab747c9297d8f7e1f301115d97cd3d2c5 Cr-Commit-Position: refs/heads/master@{#399332}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -43 lines) Patch
M ash/mus/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M cc/blink/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/arc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/safe_json/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M components/webcrypto/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M content/child/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M content/test/BUILD.gn View 1 3 chunks +1 line, -3 lines 0 comments Download
M device/battery/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M device/usb/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M device/vibration/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M device/vr/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/shell/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M media/blink/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/converters/blink/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M skia/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +0 lines, -10 lines 0 comments Download
M tools/ipc_fuzzer/message_replay/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (5 generated)
Ken Rockot(use gerrit already)
Mind doing a quick sanity check?
4 years, 6 months ago (2016-06-10 21:11:14 UTC) #3
jam
lgtm
4 years, 6 months ago (2016-06-10 21:48:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059983002/20001
4 years, 6 months ago (2016-06-10 21:53:55 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-11 00:40:42 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-11 00:40:47 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-11 00:42:34 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c547787ab747c9297d8f7e1f301115d97cd3d2c5
Cr-Commit-Position: refs/heads/master@{#399332}

Powered by Google App Engine
This is Rietveld 408576698