Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp

Issue 2059933002: hello Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: hello Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp
diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp
index 1f0d20c65d93438c17c281f8d13176dc4457eed3..2df27e7381adecf5b9ecdc7e29f7bdaa570cf202 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp
+++ b/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp
@@ -398,9 +398,9 @@ TEST_F(PaymentRequestTest, CannotCallCompleteTwice)
EXPECT_FALSE(getExceptionState().hadException());
request->show(getScriptState());
static_cast<mojom::blink::PaymentRequestClient*>(request)->OnPaymentResponse(mojom::blink::PaymentResponse::New());
- request->complete(getScriptState(), false);
+ request->complete(getScriptState(), Fail);
- request->complete(getScriptState(), true).then(MockFunction::expectNoCall(getScriptState()), MockFunction::expectCall(getScriptState()));
+ request->complete(getScriptState(), Success).then(MockFunction::expectNoCall(getScriptState()), MockFunction::expectCall(getScriptState()));
}
TEST_F(PaymentRequestTest, RejectShowPromiseOnError)
@@ -422,7 +422,7 @@ TEST_F(PaymentRequestTest, RejectCompletePromiseOnError)
request->show(getScriptState());
static_cast<mojom::blink::PaymentRequestClient*>(request)->OnPaymentResponse(mojom::blink::PaymentResponse::New());
- request->complete(getScriptState(), true).then(MockFunction::expectNoCall(getScriptState()), MockFunction::expectCall(getScriptState()));
+ request->complete(getScriptState(), Success).then(MockFunction::expectNoCall(getScriptState()), MockFunction::expectCall(getScriptState()));
static_cast<mojom::blink::PaymentRequestClient*>(request)->OnError();
}
@@ -435,7 +435,7 @@ TEST_F(PaymentRequestTest, ResolvePromiseOnComplete)
request->show(getScriptState());
static_cast<mojom::blink::PaymentRequestClient*>(request)->OnPaymentResponse(mojom::blink::PaymentResponse::New());
- request->complete(getScriptState(), true).then(MockFunction::expectCall(getScriptState()), MockFunction::expectNoCall(getScriptState()));
+ request->complete(getScriptState(), Success).then(MockFunction::expectCall(getScriptState()), MockFunction::expectNoCall(getScriptState()));
static_cast<mojom::blink::PaymentRequestClient*>(request)->OnComplete();
}
@@ -459,7 +459,7 @@ TEST_F(PaymentRequestTest, RejectCompletePromiseOnUpdateDetailsFailure)
request->show(getScriptState()).then(MockFunction::expectCall(getScriptState()), MockFunction::expectNoCall(getScriptState()));
static_cast<mojom::blink::PaymentRequestClient*>(request)->OnPaymentResponse(mojom::blink::PaymentResponse::New());
- request->complete(getScriptState(), true).then(MockFunction::expectNoCall(getScriptState()), MockFunction::expectCall(getScriptState()));
+ request->complete(getScriptState(), Success).then(MockFunction::expectNoCall(getScriptState()), MockFunction::expectCall(getScriptState()));
request->onUpdatePaymentDetailsFailure(ScriptValue::from(getScriptState(), "oops"));
}

Powered by Google App Engine
This is Rietveld 408576698