Simplify HeapSnapshotFilteredOrderedIterator implementation

Simplify HeapSnapshotFilteredOrderedIterator implementation

Introduced filtered iterator and iterator over array of indexes. This allowed to decompose HeapSnapshotFilteredOrderedIterator.

BUG=None
R=alph@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169650

[alph, 2014-03-20 09:58:04]

lgtm

https://codereview.chromium.org/205993003/diff/1/Source/devtools/front_end/He...
File Source/devtools/front_end/HeapSnapshot.js (right):

https://codereview.chromium.org/205993003/diff/1/Source/devtools/front_end/He...
Source/devtools/front_end/HeapSnapshot.js:659:
WebInspector.HeapSnapshotIndexRangeIterator = function(iterator, indexes)
annotate plz

https://codereview.chromium.org/205993003/diff/1/Source/devtools/front_end/He...
Source/devtools/front_end/HeapSnapshot.js:673: return this._position <
this._indexes.length
; missing

https://codereview.chromium.org/205993003/diff/1/Source/devtools/front_end/He...
Source/devtools/front_end/HeapSnapshot.js:2008:
WebInspector.HeapSnapshotFilteredOrderedIterator = function(iterator)
I'd suggest drop "Filtered" from the class name.

https://codereview.chromium.org/205993003/diff/1/Source/devtools/front_end/He...
Source/devtools/front_end/HeapSnapshot.js:2062: result[i] =
iterator.item().serialize();
Consider joining setIndex+item into itemByIndex

[loislo, 2014-03-20 09:58:25]

https://codereview.chromium.org/205993003/diff/1/Source/devtools/front_end/He...
File Source/devtools/front_end/HeapSnapshot.js (right):

https://codereview.chromium.org/205993003/diff/1/Source/devtools/front_end/He...
Source/devtools/front_end/HeapSnapshot.js:679: index: function()
Can we just use a free function for converting index into an item.
because it looks strange when we stick the iterator to a particular index and
don't allow it to move next.

[yurys, 2014-03-20 11:47:41]

https://codereview.chromium.org/205993003/diff/1/Source/devtools/front_end/He...
File Source/devtools/front_end/HeapSnapshot.js (right):

https://codereview.chromium.org/205993003/diff/1/Source/devtools/front_end/He...
Source/devtools/front_end/HeapSnapshot.js:659:
WebInspector.HeapSnapshotIndexRangeIterator = function(iterator, indexes)
On 2014/03/20 09:58:04, alph wrote:
> annotate plz

Done.

https://codereview.chromium.org/205993003/diff/1/Source/devtools/front_end/He...
Source/devtools/front_end/HeapSnapshot.js:673: return this._position <
this._indexes.length
On 2014/03/20 09:58:04, alph wrote:
> ; missing

Done.

https://codereview.chromium.org/205993003/diff/1/Source/devtools/front_end/He...
Source/devtools/front_end/HeapSnapshot.js:679: index: function()
On 2014/03/20 09:58:26, loislo wrote:
> Can we just use a free function for converting index into an item.
> because it looks strange when we stick the iterator to a particular index and
> don't allow it to move next.

We will need to pass it as a separate object as it needs a context (snapshot and
item's class). I'll address this in a separate patch.

https://codereview.chromium.org/205993003/diff/1/Source/devtools/front_end/He...
Source/devtools/front_end/HeapSnapshot.js:2008:
WebInspector.HeapSnapshotFilteredOrderedIterator = function(iterator)
On 2014/03/20 09:58:04, alph wrote:
> I'd suggest drop "Filtered" from the class name.

Done.

https://codereview.chromium.org/205993003/diff/1/Source/devtools/front_end/He...
Source/devtools/front_end/HeapSnapshot.js:2062: result[i] =
iterator.item().serialize();
On 2014/03/20 09:58:04, alph wrote:
> Consider joining setIndex+item into itemByIndex

Let me address this in a separate patch.

[yurys, 2014-03-20 11:51:02]

The CQ bit was checked by yurys@chromium.org

[commit-bot: I haz the power, 2014-03-20 11:51:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yurys@chromium.org/205993003/40001

[commit-bot: I haz the power, 2014-03-20 12:48:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-20 12:48:03]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[yurys, 2014-03-20 12:51:52]

Committed patchset #3 manually as r169650 (presubmit successful).