chrome/browser/resources/ntp4/nav_dot.js - Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/ntp4/nav_dot.js

Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove a few tests that were failing because webui hasn't changed yet Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js ('K') | « chrome/browser/resources/ntp4/dot_list.js ('k') | chrome/browser/resources/ntp4/page_list_view.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/ntp4/nav_dot.js

diff --git a/chrome/browser/resources/ntp4/nav_dot.js b/chrome/browser/resources/ntp4/nav_dot.js

index 964be968689b13a4e4dc86f230571b0868123c86..7703f31639d2ce5d8a87286fd7b92d5f2e87178b 100644

--- a/chrome/browser/resources/ntp4/nav_dot.js

+++ b/chrome/browser/resources/ntp4/nav_dot.js

@@ -114,7 +114,7 @@ cr.define('ntp', function() {

* @param {Event} e The KeyboardEvent.

onKeyDown_: function(e) {

- if (e.keyIdentifier == 'Enter') {

+ if (e.key == 'Enter') {

this.onClick_(e);

e.stopPropagation();

}

@@ -164,8 +164,8 @@ cr.define('ntp', function() {

* @private

onInputKeyDown_: function(e) {

- switch (e.keyIdentifier) {

- case 'U+001B': // Escape cancels edits.

+ switch (e.key) {

+ case 'Escape': // Escape cancels edits.

this.input_.value = this.displayTitle;

case 'Enter': // Fall through.

this.input_.blur();