chrome/browser/resources/history/history.js - Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/history/history.js

Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove a few tests that were failing because webui hasn't changed yet Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js ('K') | « chrome/browser/resources/extensions/extension_error.js ('k') | chrome/browser/resources/hotword_audio_verification/main.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/history/history.js

diff --git a/chrome/browser/resources/history/history.js b/chrome/browser/resources/history/history.js

index 3c22e6d4051867dd6141d05bf3782dfe5257566f..1819bdf717c2afa844c55f343398e287e290cd76 100644

--- a/chrome/browser/resources/history/history.js

+++ b/chrome/browser/resources/history/history.js

@@ -502,7 +502,7 @@ Visit.prototype.showMoreFromSite_ = function() {

Visit.prototype.handleKeydown_ = function(e) {

// Delete or Backspace should delete the entry if allowed.

- if (e.keyIdentifier == 'U+0008' || e.keyIdentifier == 'U+007F')

+ if (e.key == 'Backspace' || e.key == 'Delete')

this.removeEntryFromHistory_(e);

};