chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js - Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js

Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove a few tests that were failing because webui hasn't changed yet Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/i_search.js ('k') | chrome/browser/resources/chromeos/keyboard/keyboard_utils.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js

index 1c5f122f78e8eebcf416591605c6fa38f1ec3eaa..b87e9396998ac74c925bcc734ca09081785a69a3 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js

@@ -494,24 +494,24 @@ Panel.onKeyDown = function(event) {

if (event.altKey || event.ctrlKey || event.metaKey || event.shiftKey)

return;

- switch (event.keyIdentifier) {

- case 'Left':

+ switch (event.key) {

+ case 'ArrowLeft':

Panel.advanceActiveMenuBy(-1);

break;

- case 'Right':

+ case 'ArrowRight':

Panel.advanceActiveMenuBy(1);

break;

- case 'Up':

+ case 'ArrowUp':

Panel.advanceItemBy(-1);

break;

- case 'Down':

+ case 'ArrowDown':

Panel.advanceItemBy(1);

break;

- case 'U+001B': // Escape

+ case 'Escape':

Panel.closeMenusAndRestoreFocus();

break;

case 'Enter': // Enter

Dan Beam 2016/06/14 00:20:27 probably don't need this comment

- case 'U+0020': // Space

+ case ' ': // Space

Panel.pendingCallback_ = Panel.getCallbackForCurrentItem();

Panel.closeMenusAndRestoreFocus();

break;