Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: chrome/browser/resources/sync_confirmation/sync_confirmation.js

Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix chromeos build Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* Copyright 2015 The Chromium Authors. All rights reserved. 1 /* Copyright 2015 The Chromium Authors. All rights reserved.
2 * Use of this source code is governed by a BSD-style license that can be 2 * Use of this source code is governed by a BSD-style license that can be
3 * found in the LICENSE file. */ 3 * found in the LICENSE file. */
4 4
5 cr.define('sync.confirmation', function() { 5 cr.define('sync.confirmation', function() {
6 'use strict'; 6 'use strict';
7 7
8 function onConfirm(e) { 8 function onConfirm(e) {
9 chrome.send('confirm'); 9 chrome.send('confirm');
10 } 10 }
(...skipping 24 matching lines...) Expand all
35 } 35 }
36 36
37 function onPictureLoaded(e) { 37 function onPictureLoaded(e) {
38 $('picture-container').classList.add('loaded'); 38 $('picture-container').classList.add('loaded');
39 } 39 }
40 40
41 function onKeyDown(e) { 41 function onKeyDown(e) {
42 // If the currently focused element isn't something that performs an action 42 // If the currently focused element isn't something that performs an action
43 // on "enter" being pressed and the user hits "enter", perform the default 43 // on "enter" being pressed and the user hits "enter", perform the default
44 // action of the dialog, which is "OK, Got It". 44 // action of the dialog, which is "OK, Got It".
45 if (e.keyIdentifier == 'Enter' && 45 if (e.key == 'Enter' &&
46 !/^(A|PAPER-BUTTON)$/.test(document.activeElement.tagName)) { 46 !/^(A|PAPER-BUTTON)$/.test(document.activeElement.tagName)) {
47 $('confirmButton').click(); 47 $('confirmButton').click();
48 e.preventDefault(); 48 e.preventDefault();
49 } 49 }
50 } 50 }
51 51
52 return { 52 return {
53 clearFocus: clearFocus, 53 clearFocus: clearFocus,
54 initialize: initialize, 54 initialize: initialize,
55 setUserImageURL: setUserImageURL 55 setUserImageURL: setUserImageURL
56 }; 56 };
57 }); 57 });
58 58
59 document.addEventListener('DOMContentLoaded', sync.confirmation.initialize); 59 document.addEventListener('DOMContentLoaded', sync.confirmation.initialize);
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698