Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: chrome/browser/resources/options/home_page_overlay.js

Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix chromeos build Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 /** @const */ var Page = cr.ui.pageManager.Page; 6 /** @const */ var Page = cr.ui.pageManager.Page;
7 /** @const */ var SettingsDialog = options.SettingsDialog; 7 /** @const */ var SettingsDialog = options.SettingsDialog;
8 8
9 /** 9 /**
10 * HomePageOverlay class 10 * HomePageOverlay class
(...skipping 27 matching lines...) Expand all
38 38
39 var self = this; 39 var self = this;
40 options.Preferences.getInstance().addEventListener( 40 options.Preferences.getInstance().addEventListener(
41 'homepage_is_newtabpage', 41 'homepage_is_newtabpage',
42 this.handleHomepageIsNTPPrefChange.bind(this)); 42 this.handleHomepageIsNTPPrefChange.bind(this));
43 43
44 var urlField = $('homepage-url-field'); 44 var urlField = $('homepage-url-field');
45 urlField.addEventListener('keydown', function(event) { 45 urlField.addEventListener('keydown', function(event) {
46 // Don't auto-submit when the user selects something from the 46 // Don't auto-submit when the user selects something from the
47 // auto-complete list. 47 // auto-complete list.
48 if (event.keyIdentifier == 'Enter' && !self.autocompleteList_.hidden) 48 if (event.key == 'Enter' && !self.autocompleteList_.hidden)
49 event.stopPropagation(); 49 event.stopPropagation();
50 }); 50 });
51 urlField.addEventListener('change', this.updateFavicon_.bind(this)); 51 urlField.addEventListener('change', this.updateFavicon_.bind(this));
52 52
53 var suggestionList = new cr.ui.AutocompleteList(); 53 var suggestionList = new cr.ui.AutocompleteList();
54 suggestionList.autoExpands = true; 54 suggestionList.autoExpands = true;
55 suggestionList.requestSuggestions = 55 suggestionList.requestSuggestions =
56 this.requestAutocompleteSuggestions_.bind(this); 56 this.requestAutocompleteSuggestions_.bind(this);
57 $('home-page-overlay').appendChild(suggestionList); 57 $('home-page-overlay').appendChild(suggestionList);
58 this.autocompleteList_ = suggestionList; 58 this.autocompleteList_ = suggestionList;
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 HomePageOverlay.updateAutocompleteSuggestions = function() { 146 HomePageOverlay.updateAutocompleteSuggestions = function() {
147 var instance = HomePageOverlay.getInstance(); 147 var instance = HomePageOverlay.getInstance();
148 instance.updateAutocompleteSuggestions_.apply(instance, arguments); 148 instance.updateAutocompleteSuggestions_.apply(instance, arguments);
149 }; 149 };
150 150
151 // Export 151 // Export
152 return { 152 return {
153 HomePageOverlay: HomePageOverlay 153 HomePageOverlay: HomePageOverlay
154 }; 154 };
155 }); 155 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/options/editable_text_field.js ('k') | chrome/browser/resources/options/inline_editable_list.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698