Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: chrome/browser/resources/options/chromeos/network_list.js

Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix chromeos build Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * Partial definition of the result of networkingPrivate.getProperties()). 6 * Partial definition of the result of networkingPrivate.getProperties()).
7 * TODO(stevenjb): Replace with chrome.networkingPrivate.NetworkStateProperties 7 * TODO(stevenjb): Replace with chrome.networkingPrivate.NetworkStateProperties
8 * once that is fully speced. 8 * once that is fully speced.
9 * @typedef {{ 9 * @typedef {{
10 * ConnectionState: string, 10 * ConnectionState: string,
(...skipping 1065 matching lines...) Expand 10 before | Expand all | Expand 10 after
1076 return; 1076 return;
1077 } 1077 }
1078 1078
1079 if ($(activeMenu_).handleKeyDown(e)) { 1079 if ($(activeMenu_).handleKeyDown(e)) {
1080 e.preventDefault(); 1080 e.preventDefault();
1081 e.stopPropagation(); 1081 e.stopPropagation();
1082 } 1082 }
1083 return; 1083 return;
1084 } 1084 }
1085 1085
1086 if (e.keyIdentifier == 'Enter' || 1086 if (e.key == 'Enter' ||
1087 e.keyIdentifier == 'U+0020' /* Space */) { 1087 e.key == ' ' /* Space */) {
1088 var selectedListItem = this.getListItemByIndex( 1088 var selectedListItem = this.getListItemByIndex(
1089 this.selectionModel.selectedIndex); 1089 this.selectionModel.selectedIndex);
1090 if (selectedListItem) { 1090 if (selectedListItem) {
1091 selectedListItem.click(); 1091 selectedListItem.click();
1092 return; 1092 return;
1093 } 1093 }
1094 } 1094 }
1095 1095
1096 List.prototype.handleKeyDown.call(this, e); 1096 List.prototype.handleKeyDown.call(this, e);
1097 }, 1097 },
(...skipping 474 matching lines...) Expand 10 before | Expand all | Expand 10 after
1572 /** 1572 /**
1573 * Whether the Network list is disabled. Only used for display purpose. 1573 * Whether the Network list is disabled. Only used for display purpose.
1574 */ 1574 */
1575 cr.defineProperty(NetworkList, 'disabled', cr.PropertyKind.BOOL_ATTR); 1575 cr.defineProperty(NetworkList, 'disabled', cr.PropertyKind.BOOL_ATTR);
1576 1576
1577 // Export 1577 // Export
1578 return { 1578 return {
1579 NetworkList: NetworkList 1579 NetworkList: NetworkList
1580 }; 1580 };
1581 }); 1581 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/options/chromeos/accounts_user_name_edit.js ('k') | chrome/browser/resources/options/cookies_list.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698