Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Issue 2059903002: Remove [ Failure Pass ] expectation for video-layer-crash.html. (Closed)

Created:
4 years, 6 months ago by jbroman
Modified:
4 years, 6 months ago
Reviewers:
ajuma
CC:
blink-reviews, chromium-reviews, xidachen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove [ Failure Pass ] expectation for video-layer-crash.html. It was mildly flaky before my patch, so in all likelihood this trouble was caused only by the rebaseline bot picking a bad run on Retina (there are flaky-but-pass-on-retry failures before and after my original patch on the flakiness dashboard, and it's not obvious why this test is flaky). BUG=618693 Committed: https://crrev.com/16788ccba5871bd6a6b0deeb80151e7c0009e040 Cr-Commit-Position: refs/heads/master@{#399256}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jbroman
OK, so on the flakiness dashboard it is still occasionally flaking, but that's because this ...
4 years, 6 months ago (2016-06-10 18:43:34 UTC) #2
ajuma
On 2016/06/10 18:43:34, jbroman wrote: > OK, so on the flakiness dashboard it is still ...
4 years, 6 months ago (2016-06-10 18:50:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059903002/1
4 years, 6 months ago (2016-06-10 19:03:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 19:54:43 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 19:54:45 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 19:57:13 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16788ccba5871bd6a6b0deeb80151e7c0009e040
Cr-Commit-Position: refs/heads/master@{#399256}

Powered by Google App Engine
This is Rietveld 408576698