Remove default arguments from IFX_RenderDeviceDriver.

Remove default arguments from IFX_RenderDeviceDriver.

Committed: https://pdfium.googlesource.com/pdfium/+/2f307669ded2621f87d0b019e508f6663523f1d7

[Lei Zhang, 2016-06-11 02:00:59]

thestig@chromium.org changed reviewers:
+ dsinclair@chromium.org

[dsinclair, 2016-06-13 13:21:38]

lgtm w/ nits

+caryclark fyi.

https://codereview.chromium.org/2059883004/diff/260001/core/fxge/agg/fx_agg_d...
File core/fxge/agg/fx_agg_driver.cpp (right):

https://codereview.chromium.org/2059883004/diff/260001/core/fxge/agg/fx_agg_d...
core/fxge/agg/fx_agg_driver.cpp:34: }
nit: no {}'s

https://codereview.chromium.org/2059883004/diff/260001/core/fxge/agg/fx_agg_d...
core/fxge/agg/fx_agg_driver.cpp:39: } else {
nit: early return?

https://codereview.chromium.org/2059883004/diff/260001/core/fxge/agg/fx_agg_d...
core/fxge/agg/fx_agg_driver.cpp:56: }
nit: {}'s

https://codereview.chromium.org/2059883004/diff/260001/core/fxge/agg/fx_agg_d...
core/fxge/agg/fx_agg_driver.cpp:60: int src_r = FXARGB_R(argb), src_g =
FXARGB_G(argb), src_b = FXARGB_B(argb);
nit: one per line

https://codereview.chromium.org/2059883004/diff/260001/core/fxge/agg/fx_agg_d...
core/fxge/agg/fx_agg_driver.cpp:71: for (int col = 0; col < width; col++) {
nit: {}'s

https://codereview.chromium.org/2059883004/diff/260001/core/fxge/agg/fx_agg_d...
core/fxge/agg/fx_agg_driver.cpp:74: } else {
continue and remove else { ?

https://codereview.chromium.org/2059883004/diff/260001/core/fxge/agg/fx_agg_d...
core/fxge/agg/fx_agg_driver.cpp:116: }
nit: {}'s

https://codereview.chromium.org/2059883004/diff/260001/core/fxge/agg/fx_agg_d...
core/fxge/agg/fx_agg_driver.cpp:130: if (!pBitmap) {
nit: {}'s

https://codereview.chromium.org/2059883004/diff/260001/core/fxge/agg/fx_agg_d...
core/fxge/agg/fx_agg_driver.cpp:138: }
ditto

https://codereview.chromium.org/2059883004/diff/260001/core/fxge/agg/fx_agg_d...
core/fxge/agg/fx_agg_driver.cpp:240: }
nit: {}s

[Lei Zhang, 2016-06-13 18:14:42]

https://codereview.chromium.org/2059883004/diff/260001/core/fxge/agg/fx_agg_d...
File core/fxge/agg/fx_agg_driver.cpp (right):

https://codereview.chromium.org/2059883004/diff/260001/core/fxge/agg/fx_agg_d...
core/fxge/agg/fx_agg_driver.cpp:34: }
On 2016/06/13 13:21:37, dsinclair wrote:
> nit: no {}'s

Done.

https://codereview.chromium.org/2059883004/diff/260001/core/fxge/agg/fx_agg_d...
core/fxge/agg/fx_agg_driver.cpp:39: } else {
On 2016/06/13 13:21:38, dsinclair wrote:
> nit: early return?

Done.

https://codereview.chromium.org/2059883004/diff/260001/core/fxge/agg/fx_agg_d...
core/fxge/agg/fx_agg_driver.cpp:56: }
On 2016/06/13 13:21:37, dsinclair wrote:
> nit: {}'s

Done.

https://codereview.chromium.org/2059883004/diff/260001/core/fxge/agg/fx_agg_d...
core/fxge/agg/fx_agg_driver.cpp:60: int src_r = FXARGB_R(argb), src_g =
FXARGB_G(argb), src_b = FXARGB_B(argb);
On 2016/06/13 13:21:37, dsinclair wrote:
> nit: one per line

Done.

https://codereview.chromium.org/2059883004/diff/260001/core/fxge/agg/fx_agg_d...
core/fxge/agg/fx_agg_driver.cpp:71: for (int col = 0; col < width; col++) {
On 2016/06/13 13:21:38, dsinclair wrote:
> nit: {}'s

Done.

https://codereview.chromium.org/2059883004/diff/260001/core/fxge/agg/fx_agg_d...
core/fxge/agg/fx_agg_driver.cpp:74: } else {
On 2016/06/13 13:21:38, dsinclair wrote:
> continue and remove else { ?

Meh. Both blocks are pretty small.

https://codereview.chromium.org/2059883004/diff/260001/core/fxge/agg/fx_agg_d...
core/fxge/agg/fx_agg_driver.cpp:116: }
On 2016/06/13 13:21:37, dsinclair wrote:
> nit: {}'s

Done.

https://codereview.chromium.org/2059883004/diff/260001/core/fxge/agg/fx_agg_d...
core/fxge/agg/fx_agg_driver.cpp:130: if (!pBitmap) {
On 2016/06/13 13:21:38, dsinclair wrote:
> nit: {}'s

Done.

https://codereview.chromium.org/2059883004/diff/260001/core/fxge/agg/fx_agg_d...
core/fxge/agg/fx_agg_driver.cpp:138: }
On 2016/06/13 13:21:37, dsinclair wrote:
> ditto

Done.

https://codereview.chromium.org/2059883004/diff/260001/core/fxge/agg/fx_agg_d...
core/fxge/agg/fx_agg_driver.cpp:240: }
On 2016/06/13 13:21:37, dsinclair wrote:
> nit: {}s

Done.

[Lei Zhang, 2016-06-13 22:01:41]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-06-13 22:01:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2059883004/#ps300001
(title: "rebase")

[commit-bot: I haz the power, 2016-06-13 22:01:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2059883004/300001

[commit-bot: I haz the power, 2016-06-13 22:02:10]

Description was changed from

==========
Remove default arguments from IFX_RenderDeviceDriver.
==========

to

==========
Remove default arguments from IFX_RenderDeviceDriver.

Committed:
https://pdfium.googlesource.com/pdfium/+/2f307669ded2621f87d0b019e508f6663523...
==========

[commit-bot: I haz the power, 2016-06-13 22:02:11]

Committed patchset #16 (id:300001) as
https://pdfium.googlesource.com/pdfium/+/2f307669ded2621f87d0b019e508f6663523...