DevFS initial implementation

DevFS initial implementation.

This cl implements an experimental filesystem maintained in the vm, called dart-devfs.  This will allow service protocol users to read and write source files while the vm is running.  This is needed for the reload support for flutter.

R=turnidge@google.com

Committed: https://github.com/dart-lang/sdk/commit/1a4c2005ccc03ead445b64f10ee39a06e43cc9e7

[turnidge, 2016-06-10 18:45:33]

turnidge@google.com changed reviewers:
+ turnidge@google.com

[turnidge, 2016-06-10 18:45:35]

https://codereview.chromium.org/2059883003/diff/1/runtime/include/dart_tools_...
File runtime/include/dart_tools_api.h (right):

https://codereview.chromium.org/2059883003/diff/1/runtime/include/dart_tools_...
runtime/include/dart_tools_api.h:912: DART_EXPORT bool
Dart_IsDevFSUri(Dart_Handle uri);
Consider dropping the embedding api changes until they are actually used
somewhere.

https://codereview.chromium.org/2059883003/diff/1/runtime/lib/vmservice_patch...
File runtime/lib/vmservice_patch.dart (right):

https://codereview.chromium.org/2059883003/diff/1/runtime/lib/vmservice_patch...
runtime/lib/vmservice_patch.dart:29: native
"VMService_SendObjectRootServiceMessage";
We should document somewhere why we have two ways to send a root service message
and what our plan is going forwards.  Not sure if that should be in this file or
some other.

https://codereview.chromium.org/2059883003/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/2059883003/diff/1/runtime/vm/dart_api_impl.cc...
runtime/vm/dart_api_impl.cc:5934: return Api::NewError("%s: Invalid dart-devfs
uri '%s'.",
Make error message better. "No authority specified in...

https://codereview.chromium.org/2059883003/diff/1/runtime/vm/dev_fs.cc
File runtime/vm/dev_fs.cc (right):

https://codereview.chromium.org/2059883003/diff/1/runtime/vm/dev_fs.cc#newcod...
runtime/vm/dev_fs.cc:166: JSONArray jsarr(&jsobj, "ids");
Do we want to call this ids still?  Maybe fsNames?

https://codereview.chromium.org/2059883003/diff/1/runtime/vm/json_stream.cc
File runtime/vm/json_stream.cc (right):

https://codereview.chromium.org/2059883003/diff/1/runtime/vm/json_stream.cc#n...
runtime/vm/json_stream.cc:93: // fprintf(stderr, "Param %" Pd " is %s\n", i,
param_values[
Remove this.

https://codereview.chromium.org/2059883003/diff/1/sdk/lib/vmservice/message.dart
File sdk/lib/vmservice/message.dart (right):

https://codereview.chromium.org/2059883003/diff/1/sdk/lib/vmservice/message.d...
sdk/lib/vmservice/message.dart:119: bool _isFileSystemMethod(String method) {
Maybe _methodNeedsObjectParameters or something...

[turnidge, 2016-06-10 18:53:15]

lgtm

[turnidge, 2016-06-10 18:54:58]

Description was changed from

==========
WIP: DevFS initial implementation
patch from issue 2050393002 at patchset 1 (http://crrev.com/2050393002#ps1)
==========

to

==========
DevFS initial implementation.

This cl implements an experimental filesystem maintained in the vm, called
dart-devfs.  This will allow service protocol users to read and write source
files while the vm is running.  This is needed for the reload support for
flutter.
==========

[Cutch, 2016-06-10 19:33:54]

Description was changed from

==========
DevFS initial implementation.

This cl implements an experimental filesystem maintained in the vm, called
dart-devfs.  This will allow service protocol users to read and write source
files while the vm is running.  This is needed for the reload support for
flutter.
==========

to

==========
DevFS initial implementation.

This cl implements an experimental filesystem maintained in the vm, called
dart-devfs.  This will allow service protocol users to read and write source
files while the vm is running.  This is needed for the reload support for
flutter.

R=turnidge@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1a4c2005ccc03ead445b64f10ee39a06e43cc9e7
==========

[Cutch, 2016-06-10 19:33:56]

Committed patchset #3 (id:40001) manually as
1a4c2005ccc03ead445b64f10ee39a06e43cc9e7 (presubmit successful).