Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Issue 2059863002: [Android] Fix provision devices failure getting timeout. (Closed)

Created:
4 years, 6 months ago by mikecase (-- gone --)
Modified:
4 years, 6 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix provision devices failure getting timeout. Fixing provision devices script failing if timeout is not manually set and one of the devices is unresponsive. BUG=619088 Committed: https://crrev.com/39419395ebe93d10dde4107415decb81ae851eb4 Cr-Commit-Position: refs/heads/master@{#399270}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Made reboot_timeout an arg. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M build/android/provision_devices.py View 1 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
mikecase (-- gone --)
This is the simplest fix. Don't know if you would prefer making reboot_timeout an arg ...
4 years, 6 months ago (2016-06-10 17:40:30 UTC) #2
jbudorick
https://codereview.chromium.org/2059863002/diff/1/build/android/provision_devices.py File build/android/provision_devices.py (right): https://codereview.chromium.org/2059863002/diff/1/build/android/provision_devices.py#newcode95 build/android/provision_devices.py:95: def run_phase(phase_func, reboot=True): Yeah, let's make reboot_timeout a parameter ...
4 years, 6 months ago (2016-06-10 17:42:36 UTC) #3
mikecase (-- gone --)
https://codereview.chromium.org/2059863002/diff/1/build/android/provision_devices.py File build/android/provision_devices.py (right): https://codereview.chromium.org/2059863002/diff/1/build/android/provision_devices.py#newcode95 build/android/provision_devices.py:95: def run_phase(phase_func, reboot=True): On 2016/06/10 at 17:42:36, jbudorick wrote: ...
4 years, 6 months ago (2016-06-10 19:40:42 UTC) #4
jbudorick
lgtm
4 years, 6 months ago (2016-06-10 19:41:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059863002/20001
4 years, 6 months ago (2016-06-10 19:44:29 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-10 21:20:14 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 21:20:19 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 21:22:25 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/39419395ebe93d10dde4107415decb81ae851eb4
Cr-Commit-Position: refs/heads/master@{#399270}

Powered by Google App Engine
This is Rietveld 408576698