gn: Add chromium_builder_asan target.

gn: Add chromium_builder_asan target.

All the LKGR clusterfuzz bots build this target, so add it to allow
switching these bots to gn.

BUG=618702, 542853, 619086
TBR=eroman

Committed: https://crrev.com/3f7d4fc75b62ca7008642c5aea6233eade695da5
Cr-Commit-Position: refs/heads/master@{#399241}

[Nico, 2016-06-10 17:23:27]

thakis@chromium.org changed reviewers:
+ dpranke@chromium.org

[Nico, 2016-06-10 17:23:34]

Description was changed from

==========
gn: Add chromium_builder_asan target.

All the LKGR clusterfuzz bots build this target, so add it to allow
switching these bots to gn.

BUG=618702
==========

to

==========
gn: Add chromium_builder_asan target.

All the LKGR clusterfuzz bots build this target, so add it to allow
switching these bots to gn.

BUG=618702,542853
==========

[Nico, 2016-06-10 17:33:43]

Description was changed from

==========
gn: Add chromium_builder_asan target.

All the LKGR clusterfuzz bots build this target, so add it to allow
switching these bots to gn.

BUG=618702,542853
==========

to

==========
gn: Add chromium_builder_asan target.

All the LKGR clusterfuzz bots build this target, so add it to allow
switching these bots to gn.

BUG=618702,542853,619086
==========

[Dirk Pranke, 2016-06-10 17:47:09]

Sorry for not getting to this myself yesterday; I forgot :(.

lgtm w/ the one fix, and a question.

https://codereview.chromium.org/2059843002/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2059843002/diff/20001/BUILD.gn#newcode922
BUILD.gn:922: if (!is_chromeos && current_toolchain == host_toolchain) {
When you just run `ninja chromium_builder_asan`, that is saying that you want to
build the group target using the default_toolchain (which is the target
toolchain). We don't magically merge all of the different versions of the target
in different toolchains and build all of them.

So, the way to say that you want a dependency to be built using the host
toolchain is:

if (!is_chromeos) {
  deps += [
    "//third_party/pdfium/samples:pdfium_test($host_toolchain)",
    "//v8:v8_shell($host_toolchain)",
  ]
}

https://codereview.chromium.org/2059843002/diff/20001/build/sanitizers/BUILD.gn
File build/sanitizers/BUILD.gn (right):

https://codereview.chromium.org/2059843002/diff/20001/build/sanitizers/BUILD....
build/sanitizers/BUILD.gn:5: if (is_clang) {
So this'll exist in every checkout that uses clang?

[Nico, 2016-06-10 17:50:46]

thanks!

https://codereview.chromium.org/2059843002/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2059843002/diff/20001/BUILD.gn#newcode922
BUILD.gn:922: if (!is_chromeos && current_toolchain == host_toolchain) {
On 2016/06/10 17:47:09, Dirk Pranke wrote:
> When you just run `ninja chromium_builder_asan`, that is saying that you want
to
> build the group target using the default_toolchain (which is the target
> toolchain). We don't magically merge all of the different versions of the
target
> in different toolchains and build all of them.
> 
> So, the way to say that you want a dependency to be built using the host
> toolchain is:
> 
> if (!is_chromeos) {
>   deps += [
>     "//third_party/pdfium/samples:pdfium_test($host_toolchain)",
>     "//v8:v8_shell($host_toolchain)",
>   ]
> }

Ah, thanks, done. (gn_all has the pattern I added here; guess that target wants
something else.)

https://codereview.chromium.org/2059843002/diff/20001/build/sanitizers/BUILD.gn
File build/sanitizers/BUILD.gn (right):

https://codereview.chromium.org/2059843002/diff/20001/build/sanitizers/BUILD....
build/sanitizers/BUILD.gn:5: if (is_clang) {
On 2016/06/10 17:47:09, Dirk Pranke wrote:
> So this'll exist in every checkout that uses clang?

Yes, it's part of the clang prebuilt bundle.

(I guess iOS uses Xcode's clang, but it looks like gyp'x clang_xcode doesn't
exist in the gn build yet)

[Nico, 2016-06-10 17:53:39]

Description was changed from

==========
gn: Add chromium_builder_asan target.

All the LKGR clusterfuzz bots build this target, so add it to allow
switching these bots to gn.

BUG=618702,542853,619086
==========

to

==========
gn: Add chromium_builder_asan target.

All the LKGR clusterfuzz bots build this target, so add it to allow
switching these bots to gn.

BUG=618702,542853,619086
TBR=eroman
==========

[Nico, 2016-06-10 17:53:55]

thakis@chromium.org changed reviewers:
+ eroman@chromium.org

[Nico, 2016-06-10 17:53:56]

tbr eroman for comment-only net/OWNERS

[Nico, 2016-06-10 17:53:59]

The CQ bit was checked by thakis@chromium.org

[Nico, 2016-06-10 17:54:00]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2059843002/#ps60001
(title: "testonly")

[commit-bot: I haz the power, 2016-06-10 17:54:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2059843002/60001

[Dirk Pranke, 2016-06-10 17:55:03]

https://codereview.chromium.org/2059843002/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2059843002/diff/20001/BUILD.gn#newcode922
BUILD.gn:922: if (!is_chromeos && current_toolchain == host_toolchain) {
On 2016/06/10 17:50:45, Nico (traveling...slow) wrote:
> On 2016/06/10 17:47:09, Dirk Pranke wrote:
> > When you just run `ninja chromium_builder_asan`, that is saying that you
want
> to
> > build the group target using the default_toolchain (which is the target
> > toolchain). We don't magically merge all of the different versions of the
> target
> > in different toolchains and build all of them.
> > 
> > So, the way to say that you want a dependency to be built using the host
> > toolchain is:
> > 
> > if (!is_chromeos) {
> >   deps += [
> >     "//third_party/pdfium/samples:pdfium_test($host_toolchain)",
> >     "//v8:v8_shell($host_toolchain)",
> >   ]
> > }
> 
> Ah, thanks, done. (gn_all has the pattern I added here; guess that target
wants
> something else.)

You mean gn_only, right? Yeah, that usage is almost certainly wrong for the same
reason (and I suspect I reviewed that change and didn't catch it at the time).

[commit-bot: I haz the power, 2016-06-10 18:48:01]

Description was changed from

==========
gn: Add chromium_builder_asan target.

All the LKGR clusterfuzz bots build this target, so add it to allow
switching these bots to gn.

BUG=618702,542853,619086
TBR=eroman
==========

to

==========
gn: Add chromium_builder_asan target.

All the LKGR clusterfuzz bots build this target, so add it to allow
switching these bots to gn.

BUG=618702,542853,619086
TBR=eroman
==========

[commit-bot: I haz the power, 2016-06-10 18:48:02]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-10 18:48:10]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-10 18:51:18]

Description was changed from

==========
gn: Add chromium_builder_asan target.

All the LKGR clusterfuzz bots build this target, so add it to allow
switching these bots to gn.

BUG=618702,542853,619086
TBR=eroman
==========

to

==========
gn: Add chromium_builder_asan target.

All the LKGR clusterfuzz bots build this target, so add it to allow
switching these bots to gn.

BUG=618702,542853,619086
TBR=eroman

Committed: https://crrev.com/3f7d4fc75b62ca7008642c5aea6233eade695da5
Cr-Commit-Position: refs/heads/master@{#399241}
==========

[commit-bot: I haz the power, 2016-06-10 18:51:19]

Patchset 4 (id:??) landed as
https://crrev.com/3f7d4fc75b62ca7008642c5aea6233eade695da5
Cr-Commit-Position: refs/heads/master@{#399241}

[eroman, 2016-06-10 19:33:32]

lgtm

[Sungmann Cho, 2016-06-11 09:56:13]

sungmann.cho@navercorp.com changed reviewers:
+ sungmann.cho@navercorp.com

[Sungmann Cho, 2016-06-11 09:56:14]

Sorry to bother you, but an error is generated after landing of this CL when
running "gn gen". Am I missing something?

D:\FOSS\Chromium\src>gn gen out\debug
Waiting for editor on "D:\FOSS\Chromium\src\out\debug\args.gn"...
Generating files...
ERROR at //BUILD.gn:932:19: Undefined identifier
    if (is_win && symbol_level == 2 && target_cpu == "x86" && is_syzyasan) {
                  ^-----------

[Dirk Pranke, 2016-06-11 15:33:43]

On 2016/06/11 09:56:14, Sungmann Cho (Inactive) wrote:
> Sorry to bother you, but an error is generated after landing of this CL when
> running "gn gen". Am I missing something?
> 
> D:\FOSS\Chromium\src>gn gen out\debug
> Waiting for editor on "D:\FOSS\Chromium\src\out\debug\args.gn"...
> Generating files...
> ERROR at //BUILD.gn:932:19: Undefined identifier
>     if (is_win && symbol_level == 2 && target_cpu == "x86" && is_syzyasan) {
>                   ^-----------

I think //BUILD.gn is missing an import("//build/config/compiler/compiler.gni")
and
so symbol_level isn't technically defined. GN can be racy in this situation
unfortunately
(there's a bug there somewhere).

I'll post a fix.

[Dirk Pranke, 2016-06-11 21:06:20]

On 2016/06/11 15:33:43, Dirk Pranke wrote:
> On 2016/06/11 09:56:14, Sungmann Cho (Inactive) wrote:
> > Sorry to bother you, but an error is generated after landing of this CL when
> > running "gn gen". Am I missing something?
> > 
> > D:\FOSS\Chromium\src>gn gen out\debug
> > Waiting for editor on "D:\FOSS\Chromium\src\out\debug\args.gn"...
> > Generating files...
> > ERROR at //BUILD.gn:932:19: Undefined identifier
> >     if (is_win && symbol_level == 2 && target_cpu == "x86" && is_syzyasan) {
> >                   ^-----------
> 
> I think //BUILD.gn is missing an
import("//build/config/compiler/compiler.gni")
> and
> so symbol_level isn't technically defined. GN can be racy in this situation
> unfortunately
> (there's a bug there somewhere).
> 
> I'll post a fix.

Fix landed in #399377 ( https://codereview.chromium.org/2058363002 ).

[Sungmann Cho, 2016-06-12 01:02:26]

On 2016/06/11 21:06:20, Dirk Pranke wrote:
> On 2016/06/11 15:33:43, Dirk Pranke wrote:
> > On 2016/06/11 09:56:14, Sungmann Cho (Inactive) wrote:
> > > Sorry to bother you, but an error is generated after landing of this CL
when
> > > running "gn gen". Am I missing something?
> > > 
> > > D:\FOSS\Chromium\src>gn gen out\debug
> > > Waiting for editor on "D:\FOSS\Chromium\src\out\debug\args.gn"...
> > > Generating files...
> > > ERROR at //BUILD.gn:932:19: Undefined identifier
> > >     if (is_win && symbol_level == 2 && target_cpu == "x86" && is_syzyasan)
{
> > >                   ^-----------
> > 
> > I think //BUILD.gn is missing an
> import("//build/config/compiler/compiler.gni")
> > and
> > so symbol_level isn't technically defined. GN can be racy in this situation
> > unfortunately
> > (there's a bug there somewhere).
> > 
> > I'll post a fix.
> 
> Fix landed in #399377 ( https://codereview.chromium.org/2058363002 ).

It works! Thanks!