Issue 205983004: Use new Traversal<*Element> API in svg code for clarity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 205983004: Use new Traversal<*Element> API in svg code for clarity (Closed)

Created:
6 years, 9 months ago by Inactive

Modified:
6 years, 9 months ago

Reviewers:
pdr., Stephen Chennney

CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Use new Traversal<*Element> API in svg code for clarity Use new Traversal<*Element> API in svg code for clarity. It results in shorter / simpler code. It also makes it clearer what type of Element we are actually interested in. R= BUG=346733 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169621

Patch Set 1 #

Patch Set 2 : Fix typo #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -28 lines)			Patch
M	Source/core/svg/SVGElement.cpp	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	Source/core/svg/SVGSVGElement.cpp	View		2 chunks	+1 line, -6 lines	0 comments	Download
M	Source/core/svg/SVGUseElement.cpp	View	1	2 chunks	+7 lines, -18 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/205983004/20001

6 years, 9 months ago (2014-03-20 05:07:27 UTC) #4

Message was sent while issue was closed.

Change committed as 169621

Expand Messages | Collapse Messages